Commit ce0045f
committed
Add note about closing issues by commit messages
See telegramdesktop#2955 (comment)
Fix telegramdesktop#30671 parent 87445cc commit ce0045f
1 file changed
Lines changed: 8 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -144,9 +144,13 @@ Before you submit a pull request, please test your changes. Verify that Telegram | |||
| 144 | 144 | ||
| 145 | 145 | ### Write a good commit message | |
| 146 | 146 | ||
| 147 | - Explain why you make the changes. [More infos about a good commit message.][commit_message] | ||
| 148 | - Maybe reference also the related issue in your commit message. | ||
| 149 | - Don't forget to [sign your patch](#sign-your-work) to put it in the public domain. | ||
| 147 | + * Explain why you make the changes. [More infos about a good commit message.][commit_message] | ||
| 148 | + | ||
| 149 | + * If you fix an issue with your commit, please close the issue by [adding one of the keywords and the issue number][closing-issues-via-commit-messages] to your commit message. | ||
| 150 | + | ||
| 151 | + For example: `Fix #545` | ||
| 152 | + | ||
| 153 | + * Don't forget to [sign your patch](#sign-your-work) to put it in the public domain! | ||
| 150 | 154 | ||
| 151 | 155 | [//]: # (LINKS) | |
| 152 | 156 | [telegram]: https://telegram.org/ | |
@@ -155,3 +159,4 @@ Don't forget to [sign your patch](#sign-your-work) to put it in the public domai | |||
| 155 | 159 | [commit_message]: http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html | |
| 156 | 160 | [pr]: https://github.com/telegramdesktop/tdesktop/compare | |
| 157 | 161 | [build_instructions]: https://github.com/telegramdesktop/tdesktop/blob/master/README.md#build-instructions | |
| 162 | + [closing-issues-via-commit-messages]: https://help.github.com/articles/closing-issues-via-commit-messages/ | ||
0 commit comments