FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

refine error and warn logging · AnonymousDotNet/BotSharp@d703477 · GitHub

  1. AnonymousDotNet
  2. BotSharp

Repository navigation

Commit d703477

Browse files
Jicheng Lu
committed
refine error and warn logging
1 parent a26f918 commit d703477

35 files changed

Lines changed: 63 additions & 81 deletions

File tree

‎src/Infrastructure/BotSharp.Core/Conversations/Services/ConversationService.Migration.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ public async Task<bool> MigrateLatestStates(int batchSize = 100, int errorLimit
5353
#if DEBUG
5454
Console.WriteLine($"\r\n{error}\r\n");
5555
#else
56-
_logger.LogError($"{error}");
56+
_logger.LogError(ex, $"{error}");
5757
#endif
5858
}
5959
}

‎src/Infrastructure/BotSharp.Core/Files/Services/Instruct/FileInstructService.Pdf.cs‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ await hook.OnResponseGenerated(new InstructResponseModel
6666
}
6767
catch (Exception ex)
6868
{
69-
_logger.LogError($"Error when analyzing pdf in file service: {ex.Message}\r\n{ex.InnerException}");
69+
_logger.LogError(ex, $"Error when analyzing pdf in file service.");
7070
return content;
7171
}
7272
finally
@@ -113,7 +113,7 @@ private async Task<IEnumerable<string>> DownloadFiles(string dir, List<InstructF
113113
}
114114
catch (Exception ex)
115115
{
116-
_logger.LogWarning($"Error when saving pdf file: {ex.Message}\r\n{ex.InnerException}");
116+
_logger.LogWarning(ex, $"Error when saving pdf file.");
117117
continue;
118118
}
119119
}
@@ -141,7 +141,7 @@ private async Task<IEnumerable<string>> ConvertPdfToImages(IEnumerable<string> f
141141
}
142142
catch (Exception ex)
143143
{
144-
_logger.LogWarning($"Error when converting pdf file to images ({file}): {ex.Message}\r\n{ex.InnerException}");
144+
_logger.LogWarning(ex, $"Error when converting pdf file to images ({file}).");
145145
continue;
146146
}
147147
}

‎src/Infrastructure/BotSharp.Core/Files/Services/Instruct/FileInstructService.SelectFile.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ private async Task<IEnumerable<MessageFileModel>> SelectFiles(IEnumerable<Messag
108108
}
109109
catch (Exception ex)
110110
{
111-
_logger.LogWarning($"Error when selecting files. {ex.Message}\r\n{ex.InnerException}");
111+
_logger.LogWarning(ex, $"Error when selecting files.");
112112
return new List<MessageFileModel>();
113113
}
114114
}

‎src/Infrastructure/BotSharp.Core/Files/Services/Storage/LocalFileStorageService.Audio.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ public bool SaveSpeechFile(string conversationId, string fileName, BinaryData da
2424
}
2525
catch (Exception ex)
2626
{
27-
_logger.LogWarning($"Error when saving speech file. {fileName} ({conversationId})\r\n{ex.Message}\r\n{ex.InnerException}");
27+
_logger.LogWarning(ex, $"Error when saving speech file. {fileName} (conv id: {conversationId})");
2828
return false;
2929
}
3030
}

‎src/Infrastructure/BotSharp.Core/Files/Services/Storage/LocalFileStorageService.Conversation.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ public bool SaveMessageFiles(string conversationId, string messageId, string sou
153153
}
154154
catch (Exception ex)
155155
{
156-
_logger.LogWarning($"Error when saving message file {file.FileName}: {ex.Message}\r\n{ex.InnerException}");
156+
_logger.LogWarning(ex, $"Error when saving message file {file.FileName} (conv id: {conversationId}).");
157157
continue;
158158
}
159159
}
@@ -333,7 +333,7 @@ private async Task<IEnumerable<MessageFileModel>> GetScreenshots(string file, st
333333
}
334334
catch (Exception ex)
335335
{
336-
_logger.LogWarning($"Error when getting message file screenshots {file} (messageId: {messageId}), Error: {ex.Message}\r\n{ex.InnerException}");
336+
_logger.LogWarning(ex, $"Error when getting message file screenshots {file} (messageId: {messageId})");
337337
return files;
338338
}
339339
}

‎src/Infrastructure/BotSharp.Core/Files/Services/Storage/LocalFileStorageService.KnowledgeBase.cs‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,8 @@ public bool SaveKnowledgeBaseFile(string collectionName, string vectorStoreProvi
3131
}
3232
catch (Exception ex)
3333
{
34-
_logger.LogWarning($"Error when saving knowledge file " +
35-
$"(Vector store provider: {vectorStoreProvider}, Collection: {collectionName}, File name: {fileName})." +
36-
$"\r\n{ex.Message}\r\n{ex.InnerException}");
34+
_logger.LogWarning(ex, $"Error when saving knowledge file " +
35+
$"(Vector store provider: {vectorStoreProvider}, Collection: {collectionName}, File name: {fileName}).");
3736
return false;
3837
}
3938
}

‎src/Infrastructure/BotSharp.Core/Files/Services/Storage/LocalFileStorageService.User.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ public bool SaveUserAvatar(FileDataModel file)
4040
}
4141
catch (Exception ex)
4242
{
43-
_logger.LogWarning($"Error when saving user avatar: {ex.Message}\r\n{ex.InnerException}");
43+
_logger.LogWarning(ex, $"Error when saving user avatar (user id: {_user.Id})");
4444
return false;
4545
}
4646
}

‎src/Infrastructure/BotSharp.Core/Instructs/Functions/ExecuteTemplateFn.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ await hook.OnResponseGenerated(new InstructResponseModel
8484
catch (Exception ex)
8585
{
8686
var error = $"Error when getting agent {agent.Name} instruction response.";
87-
_logger.LogWarning($"{error} {ex.Message}\r\n{ex.InnerException}");
87+
_logger.LogWarning(ex, $"{error} (template name: {templateName})");
8888
return error;
8989
}
9090

‎src/Infrastructure/BotSharp.Core/Instructs/Services/InstructService.Instruct.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ public partial class InstructService
4545
}
4646
catch (Exception ex)
4747
{
48-
_logger.LogWarning($"Error when getting ai response, {ex.Message}\r\n{ex.InnerException}");
48+
_logger.LogWarning(ex, $"Error when getting ai response");
4949
}
5050

5151
return result;

‎src/Infrastructure/BotSharp.Core/Repository/FileRepository/FileRepository.Crontab.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ public bool UpsertCrontabItem(CrontabItem cron)
2626
}
2727
catch (Exception ex)
2828
{
29-
_logger.LogError($"Error when saving crontab item: {ex.Message}\r\n{ex.InnerException}");
29+
_logger.LogError(ex, $"Error when saving crontab item (agent id: {cron.AgentId}, conv id: {cron.ConversationId}).");
3030
return false;
3131
}
3232
}
@@ -57,7 +57,7 @@ public bool DeleteCrontabItem(string conversationId)
5757
}
5858
catch (Exception ex)
5959
{
60-
_logger.LogError($"Error when deleting crontab item (${conversationId}): {ex.Message}\r\n{ex.InnerException}");
60+
_logger.LogError(ex, $"Error when deleting crontab item (conv id: {conversationId}).");
6161
return false;
6262
}
6363
}

0 commit comments

Comments
 (0)
Back | FazBrowse Home | New Git URL