Non-allocating JavaScript object access - #687
Draft
AnsisMalins wants to merge 1 commit into
Draft
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I already know you want me to somehow ensure that the struct does not escape the scope of the callback, so I'll work on that. But I'm sure there are other parts of this pull request you will have comments about. I'm unhappy about the V8Value.FastArgs, but I did not have better ideas so far.
Usage:
V8Object person = args.GetV8Object(0); // args is V8FastArgs V8Value.FastArgs storage = default; // V8FastArg.pArg will point to this string email = person.GetProperty("email", ref storage).GetString(); // GetProperty returns a V8FastArg int age = person.GetProperty("age", ref storage).GetInteger();