submodule-TCs: stop monekypatching smmap.MapRegion with files in Windows · CoderPuppy/GitPython@3910abf · GitHub

1. CoderPuppy
2. GitPython

Repository navigation

• Code
• Pull requests
• Actions
• Projects
• Security and quality
• Insights

Commit 3910abf

Browse filesBrowse the repository at this point in the historyBrowse files

ankostis

committed

submodule-TCs: stop monekypatching smmap.MapRegion with files in Windows

Obviously it is not needed anymore, or nothing is worse without this monkeypatch.

1 parent caa0ea7 commit 3910abf
Copy full SHA for 3910abf

1 file changed

-14Lines changed: 0 additions & 14 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• git/test
  • test_submodule.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎git/test/test_submodule.py‎

Copy file name to clipboardExpand all lines: git/test/test_submodule.py

-14Lines changed: 0 additions & 14 deletions

Original file line number	Diff line number	Diff line change
@@ -38,20 +38,6 @@
38	38	import os.path as osp
39	39
40	40
41		- # Change the configuration if possible to prevent the underlying memory manager
42		- # to keep file handles open. On windows we get problems as they are not properly
43		- # closed due to mmap bugs on windows (as it appears)
44		- if is_win:
45		- try:
46		- import smmap.util # @UnusedImport
47		- smmap.util.MapRegion._test_read_into_memory = True
48		- except ImportError:
49		- sys.stderr.write("The submodule tests will fail as some files cannot be removed due to open file handles.\n")
50		- sys.stderr.write(
51		- "The latest version of gitdb uses a memory map manager which can be configured to work around this problem")
52		- # END handle windows platform
53		-
54		-
55	41	class TestRootProgress(RootUpdateProgress):
56	42
57	43	"""Just prints messages, for now without checking the correctness of the states"""

0 commit comments

Comments

0 (0)