FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Exclude dependencies from final jar by MatrixTunnel · Pull Request #40 · CommandAPI/CommandAPI · GitHub

Exclude dependencies from final jar - #40

Merged
JorelAli merged 1 commit into
CommandAPI:masterfrom
MatrixTunnel:master
Jan 7, 2019
Merged

Exclude dependencies from final jar#40
JorelAli merged 1 commit into
CommandAPI:masterfrom
MatrixTunnel:master

Conversation

Copy link
Copy Markdown
Contributor

This should be a non-breaking change and will reduce the jar size

JorelAli commented Jan 7, 2019

Copy link
Copy Markdown
Member

It doesn't necessarily reduce the jar size, since by default the dependency scope is "compile" and are not shaded into the jar, thus supplied at runtime. However, since this is good practice for a maven dependency and I'm always looking for ways to improve my knowledge of maven, I'll merge this.

JorelAli merged commit 8d32eca into CommandAPI:master Jan 7, 2019

Copy link
Copy Markdown
Contributor Author

I'm actually shading the CommandAPI into my plugin jar and I noticed it was a little large after updating the version. I looked in the jar and found that bukkit along with brigadier was shaded into it.

In this case with spigot, the bukkit and brigadier code is provided when the plugin is loaded so there's no need to include it

JorelAli commented Jan 8, 2019

Copy link
Copy Markdown
Member

I see! Thanks for clarifying!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL