updated with neccessary changes (#1709) · ComplexOW/java-design-patterns@31890f6 · GitHub

ComplexOW / java-design-patterns Public

forked from iluwatar/java-design-patterns

• Notifications You must be signed in to change notification settings
• Fork 0
• Star 0

• Code
• Pull requests
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 31890f6

Browse filesBrowse the repository at this point in the historyBrowse files

ohbus

authored

updated with neccessary changes (iluwatar#1709)

1 parent 41b1462 commit 31890f6
Copy full SHA for 31890f6

4 files changed

+16-15Lines changed: 16 additions & 15 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• .github/workflows
  • maven-ci.yml
  • maven-pr-builder.yml
• reactor/src/main/java/com/iluwatar/reactor/app
  • App.java
  • AppClient.java

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎.github/workflows/maven-ci.yml‎

Copy file name to clipboardExpand all lines: .github/workflows/maven-ci.yml

+4-4Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
@@ -40,26 +40,26 @@ jobs:
40	40	steps:
41	41
42	42	- name: Checkout Code
43		- uses: actions/checkout@master
	43	+ uses: actions/checkout@v2
44	44	with:
45	45	# Disabling shallow clone for improving relevancy of SonarQube reporting
46	46	fetch-depth: 0
47	47
48	48	- name: Set up JDK 11
49		- uses: actions/setup-java@master
	49	+ uses: actions/setup-java@v2
50	50	with:
51	51	java-version: 11
52	52	distribution: 'adopt'
53	53
54	54	- name: Cache SonarCloud packages
55		- uses: actions/cache@master
	55	+ uses: actions/cache@v2
56	56	with:
57	57	path: ~/.sonar/cache
58	58	key: ${{ runner.os }}-sonar
59	59	restore-keys: ${{ runner.os }}-sonar
60	60
61	61	- name: Cache Maven dependencies
62		- uses: actions/cache@master
	62	+ uses: actions/cache@v2
63	63	with:
64	64	path: ~/.m2/repository
65	65	key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}

Collapse file

‎.github/workflows/maven-pr-builder.yml‎

Copy file name to clipboardExpand all lines: .github/workflows/maven-pr-builder.yml

+3-3Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -38,16 +38,16 @@ jobs:
38	38
39	39	steps:
40	40	- name: Checkout Code
41		- uses: actions/checkout@master
	41	+ uses: actions/checkout@v2
42	42
43	43	- name: Set up JDK 11
44		- uses: actions/setup-java@master
	44	+ uses: actions/setup-java@v2
45	45	with:
46	46	java-version: 11
47	47	distribution: 'adopt'
48	48
49	49	- name: Cache Maven Dependecies
50		- uses: actions/cache@master
	50	+ uses: actions/cache@v2
51	51	with:
52	52	path: ~/.m2/repository
53	53	key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}

Collapse file

‎reactor/src/main/java/com/iluwatar/reactor/app/App.java‎

Copy file name to clipboardExpand all lines: reactor/src/main/java/com/iluwatar/reactor/app/App.java

+4-3Lines changed: 4 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -131,9 +131,10 @@ public void start() throws IOException {
131	131	* log requests.
132	132	*/
133	133	reactor
134		- .registerChannel(tcpChannel(6666, loggingHandler))
135		- .registerChannel(tcpChannel(6667, loggingHandler))
136		- .registerChannel(udpChannel(6668, loggingHandler))
	134	+ .registerChannel(tcpChannel(16666, loggingHandler))
	135	+ .registerChannel(tcpChannel(16667, loggingHandler))
	136	+ .registerChannel(udpChannel(16668, loggingHandler))
	137	+ .registerChannel(udpChannel(16669, loggingHandler))
137	138	.start();
138	139	}
139	140

Collapse file

‎reactor/src/main/java/com/iluwatar/reactor/app/AppClient.java‎

Copy file name to clipboardExpand all lines: reactor/src/main/java/com/iluwatar/reactor/app/AppClient.java

+5-5Lines changed: 5 additions & 5 deletions

Original file line number	Diff line number	Diff line change
@@ -63,10 +63,10 @@ public static void main(String[] args) throws IOException {
63	63	*/
64	64	public void start() throws IOException {
65	65	LOGGER.info("Starting logging clients");
66		- service.execute(new TcpLoggingClient("Client 1", 6666));
67		- service.execute(new TcpLoggingClient("Client 2", 6667));
68		- service.execute(new UdpLoggingClient("Client 3", 6668));
69		- service.execute(new UdpLoggingClient("Client 4", 6668));
	66	+ service.execute(new TcpLoggingClient("Client 1", 16666));
	67	+ service.execute(new TcpLoggingClient("Client 2", 16667));
	68	+ service.execute(new UdpLoggingClient("Client 3", 16668));
	69	+ service.execute(new UdpLoggingClient("Client 4", 16669));
70	70	}
71	71
72	72	/**
@@ -114,7 +114,7 @@ public TcpLoggingClient(String clientName, int serverPort) {
114	114
115	115	@Override
116	116	public void run() {
117		- try (Socket socket = new Socket(InetAddress.getLocalHost(), serverPort)) {
	117	+ try (var socket = new Socket(InetAddress.getLocalHost(), serverPort)) {
118	118	var outputStream = socket.getOutputStream();
119	119	var writer = new PrintWriter(outputStream);
120	120	sendLogRequests(writer, socket.getInputStream());

0 commit comments

Comments

0 (0)