FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Bypassing the existing *BaseService* HTTP abstraction · Issue #3619 · DMPRoadmap/roadmap · GitHub

Repository navigation

Bypassing the existing *BaseService* HTTP abstraction #3619

Description

The DMPonline OpenAIRE implementation does not use ExternalApis::BaseService at all.

In this PR, DataciteService and CrossrefService inherit from BaseService, but still call HTTParty.get directly. That means timeout handling, headers, and error handling are duplicated in each provider service rather than centralized.

Suggestions:

  • Extend BaseService.http_get if needed to support provider-specific headers and timeouts.
  • Have DataciteService and CrossrefService call http_get(...) instead of HTTParty.get(...) directly.
  • Keep provider services responsible for provider-specific URLs and response parsing only.

No activity

Activity on this issue will appear here.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions


      Back | FazBrowse Home | New Git URL