Reorganize the code of benchmark - #2
Merged
Dobatymo merged 1 commit intoJan 13, 2023
Merged
Dobatymo merged 1 commit into
Dobatymo merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
presidento
force-pushed
the
benchmark-refactor
branch
from
35c1890 to
aa5c640
Compare
December 11, 2022 11:59
Copy link
Copy Markdown
Contributor
Author
|
Here is a sample output with max time = 100: write
batch
read
combined
|
Sorry, something went wrong.
Decouple the common steps and database implementations. With this it is easy to add new implementations and remove missing ones. Also separate single writes and batch writes, since in almost every implementation the batch write is faster. Initiate MAX_TIME to stop spending infinite time calculating very slow implementations. Add combined case: in real world the key/value stores are not used to store the whole database, then read the whole database. In the combined case the same number of writes and reads are calculated for different database sizes. WiredTiger is missing from PyPi, so I removed that. Added SQLite WAL mode, since it is much faster even with autocommit than the existing two.
presidento
force-pushed
the
benchmark-refactor
branch
from
aa5c640 to
9860f8c
Compare
December 12, 2022 20:46
Copy link
Copy Markdown
Owner
|
Hi, thank you for your contribution. I am a bit busy right now, but I will definitely review them soon! It looks like good restructuring. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decouple the common steps and database implementations. With this it is easy to add new implementations and remove missing ones.
Also separate single writes and batch writes, since in almost every implementation the batch write is faster.
Initiate MAX_TIME to stop spending infinite time calculating very slow implementations.
Add combined case: in real world the key/value stores are not used to store the whole database, then read the whole database. In the combined case the same number of writes and reads are calculated for different database sizes.
WiredTiger is missing from PyPi, so I removed that.
Added SQLite WAL mode, since it is much faster even with autocommit than the existing two.