FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Merge pull request #8 from ENjxzlt/claude/grok-streamcontroller-plugi… · ENjxzlt/Grok-Usage-Streamcontroller@b6d74c4 · GitHub

Commit b6d74c4

Browse files
authored
Merge pull request #8 from ENjxzlt/claude/grok-streamcontroller-plugin-xva9ba
Fix settings panel crash: AdwEntryRow has no subtitle property (1.0.3)
2 parents 4f0e0bd + b801ac9 commit b6d74c4

5 files changed

Lines changed: 16 additions & 9 deletions

File tree

‎CHANGELOG.md‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# Changelog
22

3+
## 1.0.3
4+
5+
- Fixed the settings panel crashing on open (`TypeError: gobject 'AdwEntryRow' doesn't support property 'subtitle'`), reported by [@Core447](https://github.com/Core447) while reviewing the StreamController Store submission. `AdwEntryRow` has no `subtitle` property (unlike `AdwActionRow`/`AdwComboRow`, which do) — passing one as a construct argument crashed as soon as the log-path or sessions-directory rows were built. Moved that hint text to a tooltip on each row instead.
6+
37
## 1.0.2
48

59
Real-world fixes from [@parkour86](https://github.com/parkour86) testing against actual Grok Build/SuperGrok installs ([#3](https://github.com/ENjxzlt/Grok-Usage-Streamcontroller/issues/3), [#4](https://github.com/ENjxzlt/Grok-Usage-Streamcontroller/pull/4), [#5](https://github.com/ENjxzlt/Grok-Usage-Streamcontroller/pull/5), [#6](https://github.com/ENjxzlt/Grok-Usage-Streamcontroller/pull/6)):

‎about.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"author": "ENjxzlt",
33
"release-notes": {
44
"path": "CHANGELOG.md",
5-
"version": "1.0.2"
5+
"version": "1.0.3"
66
},
77
"credits": {},
88
"comments": {},

‎actions/GrokUsage/GrokUsage.py‎

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -332,15 +332,18 @@ def _settings(self) -> dict:
332332
def get_config_rows(self) -> list:
333333
settings = self._settings()
334334

335-
log_path_row = Adw.EntryRow(
336-
title=self.tr("grok-usage.log-path.title"), subtitle=self.tr("grok-usage.log-path.subtitle")
337-
)
335+
# AdwEntryRow (unlike AdwActionRow/AdwComboRow below) has no "subtitle"
336+
# property - passing one as a construct kwarg crashes with
337+
# "TypeError: gobject 'AdwEntryRow' doesn't support property
338+
# 'subtitle'" as soon as the settings panel is opened. Set it as a
339+
# tooltip instead so the hint isn't lost entirely.
340+
log_path_row = Adw.EntryRow(title=self.tr("grok-usage.log-path.title"))
341+
log_path_row.set_tooltip_text(self.tr("grok-usage.log-path.subtitle"))
338342
log_path_row.set_text(str(settings.get("log_path", DEFAULT_LOG_PATH)))
339343
log_path_row.connect("notify::text", self._on_log_path_changed)
340344

341-
sessions_dir_row = Adw.EntryRow(
342-
title=self.tr("grok-usage.sessions-dir.title"), subtitle=self.tr("grok-usage.sessions-dir.subtitle")
343-
)
345+
sessions_dir_row = Adw.EntryRow(title=self.tr("grok-usage.sessions-dir.title"))
346+
sessions_dir_row.set_tooltip_text(self.tr("grok-usage.sessions-dir.subtitle"))
344347
sessions_dir_row.set_text(str(settings.get("sessions_dir", DEFAULT_SESSIONS_DIR)))
345348
sessions_dir_row.connect("notify::text", self._on_sessions_dir_changed)
346349

‎main.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,6 @@ def __init__(self):
4747
self.register(
4848
plugin_name=self.lm.get("plugin.name"),
4949
github_repo="https://github.com/ENjxzlt/Grok-Usage-Streamcontroller",
50-
plugin_version="1.0.2",
50+
plugin_version="1.0.3",
5151
app_version="1.5.0-beta",
5252
)

‎manifest.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"version": "1.0.2",
2+
"version": "1.0.3",
33
"thumbnail": "store/Thumbnail.png",
44
"id": "dev_enjxz_GrokUsage",
55
"name": "Grok Usage",

0 commit comments

Comments
 (0)

Back | FazBrowse Home | New Git URL