Use InstanceTemplate() instead of PrototypeTemplate() for accessor me… · FesterCluck/node@fbef11b · GitHub

1. FesterCluck
2. node

Repository navigation

• Code
• Pull requests
• Actions
• Projects
• Wiki
• Security and quality
• Insights

Commit fbef11b

Browse filesBrowse the repository at this point in the historyBrowse files

zoka

authored and

ry

committed

Use InstanceTemplate() instead of PrototypeTemplate() for accessor methods

This fixes crash that used to happen when Eclipse debugging session hits the breakpoint that is set either in timer or connection callback.

1 parent 490cac0 commit fbef11b
Copy full SHA for fbef11b

2 files changed

+3-3Lines changed: 3 additions & 3 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src
  • node_net.cc
  • node_timer.cc

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/node_net.cc‎

Copy file name to clipboardExpand all lines: src/node_net.cc

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -112,12 +112,12 @@ void Connection::Initialize(v8::Handle<v8::Object> target) {
112	112	#endif
113	113
114	114	// Getter for connection.readyState
115		- constructor_template->PrototypeTemplate()->SetAccessor(
	115	+ constructor_template->InstanceTemplate()->SetAccessor(
116	116	ready_state_symbol,
117	117	ReadyStateGetter);
118	118
119	119	// Getter for connection.readyState
120		- constructor_template->PrototypeTemplate()->SetAccessor(
	120	+ constructor_template->InstanceTemplate()->SetAccessor(
121	121	fd_symbol,
122	122	FDGetter);
123	123

Collapse file

‎src/node_timer.cc‎

Copy file name to clipboardExpand all lines: src/node_timer.cc

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -27,7 +27,7 @@ Timer::Initialize (Handle<Object> target)
27	27	NODE_SET_PROTOTYPE_METHOD(constructor_template, "start", Timer::Start);
28	28	NODE_SET_PROTOTYPE_METHOD(constructor_template, "stop", Timer::Stop);
29	29
30		- constructor_template->PrototypeTemplate()->SetAccessor(repeat_symbol,
	30	+ constructor_template->InstanceTemplate()->SetAccessor(repeat_symbol,
31	31	RepeatGetter, RepeatSetter);
32	32
33	33	target->Set(String::NewSymbol("Timer"), constructor_template->GetFunction());

0 commit comments

Comments

0 (0)