Commit 9e4c410
authored
Switch devcontainer to use Node.js 18. (microsoft#55299)
Also moved certain fields to `customizations`.1 parent 7eece9f commit 9e4c410
2 files changed
Lines changed: 19 additions & 15 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1,7 +1,7 @@ | |||
| 1 | - # See here for image contents: https://github.com/microsoft/vscode-dev-containers/tree/v0.154.0/containers/javascript-node/.devcontainer/base.Dockerfile | ||
| 1 | + # See here for image contents: https://github.com/microsoft/vscode-dev-containers/blob/v0.245.2/containers/javascript-node/.devcontainer/base.Dockerfile | ||
| 2 | 2 | ||
| 3 | - # [Choice] Node.js version: 14, 12, 10 | ||
| 4 | - ARG VARIANT="14-buster" | ||
| 3 | + # [Choice] Node.js version: 18, 16, 14 | ||
| 4 | + ARG VARIANT="18-buster" | ||
| 5 | 5 | FROM mcr.microsoft.com/vscode/devcontainers/javascript-node:0-${VARIANT} | |
| 6 | 6 | ||
| 7 | 7 | RUN sudo -u node npm install -g hereby | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -3,20 +3,24 @@ | |||
| 3 | 3 | "build": { | |
| 4 | 4 | "dockerfile": "Dockerfile", | |
| 5 | 5 | "args": { | |
| 6 | - "VARIANT": "14" | ||
| 6 | + "VARIANT": "18" | ||
| 7 | 7 | } | |
| 8 | 8 | }, | |
| 9 | - "settings": { | ||
| 10 | - "terminal.integrated.defaultProfile.linux": "bash", | ||
| 11 | - "terminal.integrated.profiles.linux": { | ||
| 12 | - "bash": { | ||
| 13 | - "path": "/bin/bash", | ||
| 14 | - "icon": "terminal-bash", | ||
| 9 | + "customizations": { | ||
| 10 | + "vscode": { | ||
| 11 | + "settings": { | ||
| 12 | + "terminal.integrated.defaultProfile.linux": "bash", | ||
| 13 | + "terminal.integrated.profiles.linux": { | ||
| 14 | + "bash": { | ||
| 15 | + "path": "/bin/bash", | ||
| 16 | + "icon": "terminal-bash" | ||
| 17 | + } | ||
| 18 | + } | ||
| 15 | 19 | }, | |
| 16 | - }, | ||
| 20 | + "extensions": [ | ||
| 21 | + "dbaeumer.vscode-eslint" | ||
| 22 | + ] | ||
| 23 | + } | ||
| 17 | 24 | }, | |
| 18 | - "extensions": [ | ||
| 19 | - "dbaeumer.vscode-eslint" | ||
| 20 | - ], | ||
| 21 | 25 | "remoteUser": "node" | |
| 22 | - } | ||
| 26 | + } | ||
0 commit comments