FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix for #2463 and other todo notes · HAPI-Tech-Solution/processing@b8f36d4 · GitHub

Repository navigation

Commit b8f36d4

Browse files
committed
fix for processing#2463 and other todo notes
1 parent 675456b commit b8f36d4

4 files changed

Lines changed: 69 additions & 11 deletions

File tree

‎app/src/processing/app/Editor.java‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1492,7 +1492,7 @@ public void stopCompoundEdit() {
14921492

14931493

14941494
public int getScrollPosition() {
1495-
return textarea.getScrollPosition();
1495+
return textarea.getVerticalScrollPosition();
14961496
}
14971497

14981498

@@ -1761,22 +1761,22 @@ public void handleAutoFormat() {
17611761
} else {
17621762
// replace with new bootiful text
17631763
// selectionEnd hopefully at least in the neighborhood
1764-
int scrollPos = textarea.getScrollPosition();
1764+
int scrollPos = textarea.getVerticalScrollPosition();
17651765
setText(formattedText);
17661766
setSelection(selectionEnd, selectionEnd);
17671767

17681768
// Put the scrollbar position back, otherwise it jumps on each format.
17691769
// Since we're not doing a good job of maintaining position anyway,
17701770
// a more complicated workaround here is fairly pointless.
17711771
// http://code.google.com/p/processing/issues/detail?id=1533
1772-
if (scrollPos != textarea.getScrollPosition()) {
1772+
if (scrollPos != textarea.getVerticalScrollPosition()) {
17731773
// boolean wouldBeVisible =
17741774
// scrollPos >= textarea.getFirstLine() &&
17751775
// scrollPos < textarea.getLastLine();
17761776
//
17771777
// // if it was visible, and now it's not, then allow the scroll
17781778
// if (!(wasVisible && !wouldBeVisible)) {
1779-
textarea.setScrollPosition(scrollPos);
1779+
textarea.setVerticalScrollPosition(scrollPos);
17801780
// }
17811781
}
17821782
getSketch().setModified(true);

‎app/src/processing/app/Recent.java‎

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,14 @@ private void updateMenu(JMenu menu) {
118118
menu.removeAll();
119119
String sketchbookPath = Base.getSketchbookFolder().getAbsolutePath();
120120
// String homePath = System.getProperty("user.home");
121-
for (final Record rec : records) {
121+
for (Record rec : records) {
122+
updateMenuRecord(menu, rec, sketchbookPath);
123+
}
124+
}
125+
126+
127+
private void updateMenuRecord(JMenu menu, final Record rec, String sketchbookPath) {
128+
try {
122129
String recPath = new File(rec.getPath()).getParent();
123130
String purtyPath = null;
124131

@@ -197,6 +204,11 @@ public void actionPerformed(ActionEvent e) {
197204
});
198205
//menu.add(item);
199206
menu.insert(item, 0);
207+
208+
} catch (Exception e) {
209+
// Strange things can happen... report them for the geeky and move on:
210+
// https://github.com/processing/processing/issues/2463
211+
e.printStackTrace();
200212
}
201213
}
202214

‎core/todo.txt‎

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,29 @@
11
0226 core
22
X fix parsing with missing categorical values
3+
X fix for splice() throwing a ClassCastException with other object types
4+
X https://github.com/processing/processing/issues/1445
5+
X https://github.com/processing/processing/pull/2461
6+
X add candDraw() method to the retina renderer
7+
X fix sketchPath() issue when used in another environment
8+
9+
andres
10+
X Fonts from loadFont() show up as blocks in P3D (regression)
11+
X https://github.com/processing/processing/issues/2465
12+
13+
_ "Buffers have not been created" error for sketches w/o draw()
14+
_ https://github.com/processing/processing/issues/2469
15+
_ could not reproduce
16+
17+
net
18+
X add disconnectEvent() to Server
19+
X https://github.com/processing/processing/pull/2466
20+
X https://github.com/processing/processing/issues/2133
21+
_ decide how this should actually be handled
22+
_ was disconnect always there?
23+
_ will need documentation
24+
_ modernize Client/Server code to use synchronized lists
25+
_ do we let people use the public vars in Server and Client?
26+
_ are they documented?
327

428

529
_ XML.getChildren() throwing NPE when getInt() called on non-existent var
@@ -34,6 +58,7 @@ _ https://github.com/processing/processing/issues/2012
3458
_ may have been introduced between 2.0b7 and 2.0b8
3559
_ https://github.com/processing/processing/issues/2275
3660
_ https://github.com/processing/processing/issues/2276
61+
_ https://github.com/processing/processing/issues/2483
3762
_ add option to have full screen span across screens
3863
_ display=all in cmd line
3964
_ sketchDisplay() -> 0 for all, or 1, 2, 3...

‎todo.txt‎

Lines changed: 27 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,24 @@
11
0226 pde
2+
X sketches only starting once, or half-starting and hanging
3+
X https://github.com/processing/processing/issues/2402
4+
X https://github.com/processing/processing/pull/2455
5+
X reopen current sketch in new mode editor if file extension is compatible
6+
X https://github.com/processing/processing/pull/2457
7+
X https://github.com/processing/processing/issues/2456
8+
X crash in the 'recent' menu on startup
9+
X https://github.com/processing/processing/issues/2463
10+
X sketchbook location is set to an actual sketch (huh?)
211

312

413
high
14+
_ exported apps on Windows 64 not working?
15+
_ https://github.com/processing/processing/issues/2468
516
_ sketch sometimes simply does not launch
617
_ https://github.com/processing/processing/issues/2402
718
_ https://github.com/processing/processing/pull/2455
819
_ exported apps reporting as "damaged" on OS X
9-
_ https://github.com/processing/processing/issues/2095
20+
_ JNA conflicts can be avoided with a -D option
21+
_ https://github.com/processing/processing/issues/2239
1022
_ QuickReference tool was able to bring down the environment
1123
_ https://github.com/processing/processing/issues/2229
1224
_ tab characters not recognized/drawn in the editor (2.1)
@@ -23,11 +35,17 @@ _ maybe OS X Java can't look in subfolders? (just auto-adds things)
2335

2436

2537
medium
38+
_ import static causes exception (with fix)
39+
_ https://github.com/processing/processing/issues/8
40+
_ https://github.com/processing/processing/pull/2273
2641
_ re/move things from Google Code downloads
2742
_ https://code.google.com/p/support/wiki/DownloadsFAQ
2843
_ actual help with cleaning out the repo
2944
_ https://github.com/processing/processing/issues/1898
3045
_ requires re-forking, so still a ton of work
46+
_ remove non-web stuff from web
47+
_ remove non-android stuff from android
48+
_ remove web and android from the main repo
3149
_ add font fixes to the rest of the API
3250
_ https://github.com/processing/processing/commit/eaff673d173b2d27f276cf5c59e3abf6c0fab86b
3351
_ g2.setRenderingHint(RenderingHints.KEY_FRACTIONALMETRICS,
@@ -37,8 +55,6 @@ _ https://github.com/processing/processing/issues/2349
3755
_ (we can do this now since we're actually doing the embedding)
3856
_ get stack trace issues with NPE
3957
_ https://github.com/processing/processing/pull/2359
40-
_ JNA conflicts can be avoided with a -D option
41-
_ https://github.com/processing/processing/issues/2239
4258
_ dataPath() not working when app is not run from app dir
4359
_ https://github.com/processing/processing/issues/2195
4460
_ should default to the local Java on Windows and Linux
@@ -69,14 +85,17 @@ _ emacs style errors in commander aren't quite right
6985
_ https://github.com/processing/processing/issues/2158
7086
_ export application folder location (for Manindra)
7187
_ https://github.com/processing/processing/issues/2399
72-
_ import static causes exception (with fix)
73-
_ https://github.com/processing/processing/issues/8
74-
_ https://github.com/processing/processing/pull/2273
7588
_ add documentation for how to run mode development from Eclipse
7689
_ implementation/changes from JDF
90+
_ modes are being loaded multiple times, which can cause trouble
91+
_ add minimum version required (or max version?) to libraries/modes/etc
7792

7893

7994
pulls
95+
_ if/else formatting is broken
96+
_ https://github.com/processing/processing/pull/2477
97+
_ fix for various net issues
98+
_ https://github.com/processing/processing/pull/2475
8099
_ may need a progress bar for "save as"
81100
_ or just the file copy function in general
82101
_ since it may take a long time (i.e. 1000s of screen grabs)
@@ -489,6 +508,7 @@ _ but don't do this with untitled, cuz it kinda stinks
489508
_ this is too weird--just put examples into individual zip files
490509
_ mark example files as untitled
491510
_ though will that require the sketch to be saved before export?
511+
_ https://github.com/processing/processing/issues/2459
492512
_ examples window sketches should load in proper environment
493513
_ write build.xml file to automatically update the examples
494514
_ sketch.isReadOnly returns false for examples coming from multiple modes
@@ -565,6 +585,7 @@ _ https://github.com/processing/processing/issues/943
565585

566586
PDE / Manager
567587

588+
_ ability to cancel a download/install
568589
_ we shouldn't use .properties extension for modes, et al
569590
_ because a .properties file is iso8859-1
570591
_ make note that .properties file *must* be utf-8

0 commit comments

Comments
 (0)

Back | FazBrowse Home | New Git URL