Add a custom ENTRYPOINT on top of the existing ENTRYPOINT. · HadokenCode/docker-python@dfbe82e · GitHub

HadokenCode / docker-python Public

forked from Kaggle/docker-python

• Notifications You must be signed in to change notification settings
• Fork 0
• Star 0

• Code
• Pull requests
• Actions
• Projects
• Wiki
• Security and quality
• Insights

Additional navigation options

Commit dfbe82e

Browse filesBrowse the repository at this point in the historyBrowse files

d1jang

committed

Add a custom ENTRYPOINT on top of the existing ENTRYPOINT.

When a docker run runs with this change, it's running under tini as follows: root@byod-test-x1qm:/home/kaggle_admin/tmp# docker ps CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES 955c97d95ebd kaggle/python-build "/usr/bin/tini -- /r…" 5 minutes ago Up 5 minutes hungry_ritchie root@byod-test-x1qm:/home/kaggle_admin/tmp#

1 parent b404a22 commit dfbe82e
Copy full SHA for dfbe82e

2 files changed

+8-4Lines changed: 8 additions & 4 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• Dockerfile
• kaggle_tools_update.Dockerfile

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎Dockerfile‎

Copy file name to clipboardExpand all lines: Dockerfile

+4-2Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -526,8 +526,10 @@ ENV MPLBACKEND "agg"
526	526	# Set up an initialization script to be executed before any other commands initiated by the user.
527	527	ADD patches/entrypoint.sh /root/entrypoint.sh
528	528	RUN chmod +x /root/entrypoint.sh
529		- # This script gets executed by "docker run <image> <command>" and it runs <command> at the end of its execution.
530		- ENTRYPOINT ["/root/entrypoint.sh"]
	529	+ # This script gets executed by "docker run <image> <command>" and it runs <command> at the end of its execution.
	530	+ # NOTE: ENTRYPOINT set by "FROM <image>" should preceed the our own custom entrypoint.
	531	+ # Specifically, tini can be combined with another entrypoint (https://github.com/krallin/tini).
	532	+ ENTRYPOINT ["/usr/bin/tini", "--", "/root/entrypoint.sh"]
531	533
532	534	# Finally, apply any locally defined patches.
533	535	RUN /bin/bash -c \

Collapse file

‎kaggle_tools_update.Dockerfile‎

Copy file name to clipboardExpand all lines: kaggle_tools_update.Dockerfile

+4-2Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -23,5 +23,7 @@ RUN pip install --upgrade git+https://github.com/Kaggle/learntools
23	23	# Set up an initialization script to be executed before any other commands initiated by the user.
24	24	ADD patches/entrypoint.sh /root/entrypoint.sh
25	25	RUN chmod +x /root/entrypoint.sh
26		- # This script gets executed by "docker run <image> <command>" and it runs <command> at the end of its execution.
27		- ENTRYPOINT ["/root/entrypoint.sh"]
	26	+ # This script gets executed by "docker run <image> <command>" and it runs <command> at the end of its execution.
	27	+ # NOTE: ENTRYPOINT set by "FROM <image>" should preceed the our own custom entrypoint.
	28	+ # Specifically, tini can be combined with another entrypoint (https://github.com/krallin/tini).
	29	+ ENTRYPOINT ["/usr/bin/tini", "--", "/root/entrypoint.sh"]

0 commit comments

Comments

0 (0)