FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Playing with tests by fisx · Pull Request #45 · Haskell-Things/HSlice · GitHub

Playing with tests - #45

Draft
fisx wants to merge 1 commit into
Haskell-Things:masterfrom
fisx:test-suite-in-prod
Draft

fisx wants to merge 1 commit into
Haskell-Things:masterfrom
fisx:test-suite-in-prod

Conversation

fisx commented Jun 12, 2021

Copy link
Copy Markdown
Collaborator

A bit of stream of consciousness on what's happening here: when reviewing #42, I got confused and followed an itch to rewrite a few helpers. Then I wanted to test the new implementation against the old, and found it awkward to have to switch between /tests and /src, so I started to implement the test suite in the prod modules. I think this would only increase the binary sizes a little, not runtime performance, while on the other hand moving tests and tested code closer together, which would make it more accessible and easier to handle. Kinda what I like about doctests. Then I found that the types accomodate illegal values, and the tests fail because of my naive Arbitrary instances. Then I was calculating how much time I have left before I need to take an extensive break from this project again, and grew a bit weary.

So I decided to at least share how far I got. Maybe you like the idea of testing in prod, and maybe you like my alternative implementations of the helpers. Please steal any and all of it, or give me a thumbs up and I might get this into a mergeable shape at some point.

Copy link
Copy Markdown
Member

worth the read, thanks. :)

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL