Increase timeout for usersecretsclient, add test case for wasSuccesfu… · HpcDataLab/docker-python@4cd0b76 · GitHub

1. HpcDataLab
2. docker-python

Repository navigation

• Code
• Pull requests
• Actions
• Projects
• Security and quality
• Insights

Commit 4cd0b76

Browse filesBrowse the repository at this point in the historyBrowse files

vimota

committed

Increase timeout for usersecretsclient, add test case for wasSuccesful: false.

1 parent fe26648 commit 4cd0b76
Copy full SHA for 4cd0b76

2 files changed

+16-5Lines changed: 16 additions & 5 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• patches
  • kaggle_secrets.py
• tests
  • test_user_secrets.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎patches/kaggle_secrets.py‎

Copy file name to clipboardExpand all lines: patches/kaggle_secrets.py

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -11,7 +11,7 @@
11	11	_KAGGLE_DEFAULT_URL_BASE = "https://www.kaggle.com"
12	12	_KAGGLE_URL_BASE_ENV_VAR_NAME = "KAGGLE_URL_BASE"
13	13	_KAGGLE_USER_SECRETS_TOKEN_ENV_VAR_NAME = "KAGGLE_USER_SECRETS_TOKEN"
14		- TIMEOUT_SECS = 10
	14	+ TIMEOUT_SECS = 40
15	15
16	16
17	17	class CredentialError(Exception):

Collapse file

‎tests/test_user_secrets.py‎

Copy file name to clipboardExpand all lines: tests/test_user_secrets.py

+15-4Lines changed: 15 additions & 4 deletions

Original file line number	Diff line number	Diff line change
@@ -10,7 +10,7 @@
10	10	from google.cloud import bigquery
11	11	from kaggle_secrets import (_KAGGLE_URL_BASE_ENV_VAR_NAME,
12	12	_KAGGLE_USER_SECRETS_TOKEN_ENV_VAR_NAME,
13		- CredentialError, UserSecretsClient)
	13	+ CredentialError, UserSecretsClient, BackendError)
14	14
15	15	_TEST_JWT = 'test-secrets-key'
16	16
@@ -37,7 +37,7 @@ def do_POST(s):
37	37	class TestUserSecrets(unittest.TestCase):
38	38	SERVER_ADDRESS = urlparse(os.getenv(_KAGGLE_URL_BASE_ENV_VAR_NAME))
39	39
40		- def _test_client(self, client_func, expected_path, expected_body, secret):
	40	+ def _test_client(self, client_func, expected_path, expected_body, secret=None, success=True):
41	41	_request = {}
42	42
43	43	class AccessTokenHandler(UserSecretsHTTPHandler):
@@ -49,7 +49,10 @@ def set_request(self):
49	49	_request['headers'] = self.headers
50	50
51	51	def get_response(self):
52		- return {'result': {'secret': secret, 'secretType': 'refreshToken', 'secretProvider': 'google'}, 'wasSuccessful': True}
	52	+ if success:
	53	+ return {'result': {'secret': secret, 'secretType': 'refreshToken', 'secretProvider': 'google'}, 'wasSuccessful': "true"}
	54	+ else:
	55	+ return {'wasSuccessful': "false"}
53	56
54	57	env = EnvironmentVarGuard()
55	58	env.set(_KAGGLE_USER_SECRETS_TOKEN_ENV_VAR_NAME, _TEST_JWT)
@@ -87,4 +90,12 @@ def call_get_access_token():
87	90	secret_response = client.get_bigquery_access_token()
88	91	self.assertEqual(secret_response, secret)
89	92	self._test_client(call_get_access_token,
90		- '/requests/GetUserSecretRequest', {'Target': 1, 'JWE': _TEST_JWT}, secret)
	93	+ '/requests/GetUserSecretRequest', {'Target': 1, 'JWE': _TEST_JWT}, secret=secret)
	94	+
	95	+ def test_get_access_token_handles_unsuccessful(self):
	96	+ def call_get_access_token():
	97	+ client = UserSecretsClient()
	98	+ with self.assertRaises(BackendError):
	99	+ client.get_bigquery_access_token()
	100	+ self._test_client(call_get_access_token,
	101	+ '/requests/GetUserSecretRequest', {'Target': 1, 'JWE': _TEST_JWT}, success=False)

0 commit comments

Comments

0 (0)