Fix catalyst test. (#973) · JasonYangCode/docker-python@b5bb7e9 · GitHub

JasonYangCode / docker-python Public

forked from Kaggle/docker-python

• Notifications You must be signed in to change notification settings
• Fork 0
• Star 1

• Code
• Pull requests
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit b5bb7e9

Browse filesBrowse the repository at this point in the historyBrowse files

rosbo

authored

Fix catalyst test. (Kaggle#973)

* Fix catalyst test. Catalyst 21.x was released on 3/13. We were using 20.x. This release included a breaking change for the CheckpointCallback class which required updating our test. http://b/182904788 * Relax nnabla addition check

1 parent ba831d3 commit b5bb7e9
Copy full SHA for b5bb7e9

2 files changed

+5-5Lines changed: 5 additions & 5 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• tests
  • test_catalyst.py
  • test_nnabla.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎tests/test_catalyst.py‎

Copy file name to clipboardExpand all lines: tests/test_catalyst.py

+4-4Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
@@ -141,10 +141,10 @@ def test_mnist(self):
141	141	logdir=logdir,
142	142	num_epochs=num_epochs,
143	143	verbose=False,
144		- callbacks=[CheckpointCallback(save_n_best=3)]
	144	+ callbacks=[CheckpointCallback(save_n_best=3, use_runner_logdir=True)]
145	145	)
146	146
147		- with open('./logs/checkpoints/_metrics.json') as f:
	147	+ with open('./logs/_metrics.json') as f:
148	148	metrics = json.load(f)
149		- self.assertTrue(metrics['train.3']['loss'] < metrics['train.1']['loss'])
150		- self.assertTrue(metrics['best']['loss'] < 0.35)
	149	+ self.assertTrue(metrics['train.3']['valid']['loss'] < metrics['train.1']['valid']['loss'])
	150	+ self.assertTrue(metrics['best']['valid']['loss'] < 0.35)

Collapse file

‎tests/test_nnabla.py‎

Copy file name to clipboardExpand all lines: tests/test_nnabla.py

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -20,7 +20,7 @@ def test_addition(self):
20	20	# forward
21	21	c.forward()
22	22
23		- self.assertAlmostEqual(c.d, a.d + b.d)
	23	+ self.assertAlmostEqual(c.d, a.d + b.d, places=3)
24	24
25	25	@gpu_test
26	26	def test_cuda_ext(self):

0 commit comments

Comments

0 (0)