FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore(tooling): add q as generator dependency · Java1024/ionic@9c9895b · GitHub

Repository navigation

Commit 9c9895b

Browse files
committed
chore(tooling): add q as generator dependency
1 parent b8aec70 commit 9c9895b

3 files changed

Lines changed: 10 additions & 14 deletions

File tree

‎package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
"es6-shim": "^0.33.6",
1919
"inquirer": "^0.11.0",
2020
"lodash": "^3.10.1",
21+
"q": "^1.4.1",
2122
"reflect-metadata": "0.1.1",
2223
"shelljs": "^0.5.3",
2324
"zone.js": "0.5.8"
@@ -57,7 +58,6 @@
5758
"minimist": "^1.1.3",
5859
"node-html-encoder": "0.0.2",
5960
"node-libs-browser": "^0.5.2",
60-
"q": "^1.4.1",
6161
"request": "2.53.0",
6262
"run-sequence": "^1.1.0",
6363
"semver": "^5.0.1",

‎tooling/generate.js‎

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ Generate.__defineGetter__('generators', function() {
1010
if (!Generate._generators) {
1111
Generate._generators = Generate.loadGenerators();
1212
}
13-
13+
1414
return Generate._generators;
1515
});
1616

@@ -24,21 +24,17 @@ Generate.generate = function generate(options) {
2424
if (!options) {
2525
throw new Error('No options passed to generator');
2626
}
27-
27+
2828
//add optional logger for CLI or other tools
2929
if (options.log) {
3030
Generate.log = options.log;
3131
}
3232

33-
if (options.q) {
34-
Generate.q = options.q;
35-
}
36-
3733
if (!options.generatorName) {
3834
options.generatorName = 'page';
3935
}
4036

41-
var generateOptions = {
37+
var generateOptions = {
4238
appDirectory: options.appDirectory,
4339
fileAndClassName: Generate.fileAndClassName(options.name),
4440
javascriptClassName: Generate.javascriptClassName(options.name),
@@ -78,7 +74,7 @@ Generate.loadGenerator = function loadGenerator(file) {
7874
}
7975
return generateModule;
8076
};
81-
77+
8278
Generate.loadGenerators = function loadGenerators() {
8379
var generators = {};
8480
fs.readdirSync(path.join(__dirname, 'generators'))
@@ -92,7 +88,7 @@ Generate.loadGenerators = function loadGenerators() {
9288
return generators;
9389
};
9490

95-
/*
91+
/*
9692
Will take options to render an html, js, or scss template.
9793
options:
9894
they differ based on what is needed in template

‎tooling/generators/page-tabs/index.js‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
var fs = require('fs'),
22
path = require('path'),
33
inquirer = require('inquirer'),
4+
Q = require('q'),
45
Generator = module.exports,
56
Generate = require('../../generate');
67

@@ -16,7 +17,7 @@ Generator.validate = function(input) {
1617
Generator.numberNames = ['first', 'second', 'third', 'fourth', 'fifth'];
1718

1819
Generator.promptForTabCount = function promptForTabCount() {
19-
var q = Generate.q.defer();
20+
var q = Q.defer();
2021

2122
inquirer.prompt({choices: ['1', '2', '3', '4', '5'], message: 'How many tabs will you have?', name: 'count', type: 'list', validate: Generator.validate}, function(result) {
2223
q.resolve(result.count);
@@ -26,7 +27,7 @@ Generator.promptForTabCount = function promptForTabCount() {
2627
};
2728

2829
Generator.promptForTabName = function promptForTabName(tabIndex, options) {
29-
var q = Generate.q.defer();
30+
var q = Q.defer();
3031

3132
inquirer.prompt({message: 'Enter the ' + Generator.numberNames[tabIndex] + ' tab name:', name: 'name', type: 'input'}, function(nameResult) {
3233
Generator.tabs.push({ appDirectory: options.appDirectory, fileAndClassName: Generate.fileAndClassName(nameResult.name), javascriptClassName: Generate.javascriptClassName(nameResult.name), name: nameResult.name });
@@ -39,7 +40,6 @@ Generator.promptForTabName = function promptForTabName(tabIndex, options) {
3940
Generator.run = function run(options) {
4041
// console.log('got options!', options);
4142

42-
// Generator.q = Generate.q;
4343
//Need to query user for tabs:
4444
options.rootDirectory = options.rootDirectory || path.join('www', 'app');
4545
var savePath = path.join(options.appDirectory, options.rootDirectory, options.fileAndClassName);
@@ -49,7 +49,7 @@ Generator.run = function run(options) {
4949
return Generator.promptForTabCount()
5050
.then(function(count) {
5151
console.log('count', count);
52-
var promise = Generate.q();
52+
var promise = Q();
5353
for(var i = 0, j = parseInt(count); i < j; i++) {
5454
(function(index) {
5555
promise = promise.then(function() {

0 commit comments

Comments
 (0)

Back | FazBrowse Home | New Git URL