New rule to prevent nested function declaration that causes an issue … · Java1024/ionic@fcfd9fe · GitHub

1. Java1024
2. ionic

Repository navigation

• Code
• Pull requests
• Actions
• Projects
• Security and quality
• Insights

Commit fcfd9fe

Browse filesBrowse the repository at this point in the historyBrowse files

Justin Willis

authored and

Justin Willis

committed

New rule to prevent nested function declaration that causes an issue with strict mode

1 parent dca6540 commit fcfd9fe
Copy full SHA for fcfd9fe

2 files changed

+7-1Lines changed: 7 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• package.json
• tslint.json

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎package.json‎

Copy file name to clipboardExpand all lines: package.json

+2-1Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -80,6 +80,7 @@
80	80	"systemjs": "0.19.6",
81	81	"through2": "^0.6.3",
82	82	"tslint": "^3.7.1",
	83	+ "tslint-eslint-rules": "^1.2.0",
83	84	"typescript": "1.8.7",
84	85	"vinyl": "^0.4.6",
85	86	"webpack": "^1.12.2",
@@ -90,4 +91,4 @@
90	91	"path": "node_modules/ionic-cz-conventional-changelog"
91	92	}
92	93	}
93		- }
	94	+ }

Collapse file

‎tslint.json‎

Copy file name to clipboardExpand all lines: tslint.json

+5Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -1,4 +1,5 @@
1	1	{
	2	+ "rulesDirectory": "node_modules/tslint-eslint-rules/dist/rules",
2	3	"rules": {
3	4	"class-name": true,
4	5	"comment-format": [
@@ -52,6 +53,10 @@
52	53	"check-operator",
53	54	"check-separator",
54	55	"check-type"
	56	+ ],
	57	+ "no-inner-declarations": [
	58	+ true,
	59	+ "functions"
55	60	]
56	61	}
57	62	}

0 commit comments

Comments

0 (0)