FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix tests for PHP 5.3 · JavaDevl/DesignPatternsPHP@eda331e · GitHub

/ DesignPatternsPHP Public
forked from DesignPatternsPHP/DesignPatternsPHP

Commit eda331e

Browse files
bocharsky-bw
committed
Fix tests for PHP 5.3
1 parent a4defb2 commit eda331e

4 files changed

Lines changed: 61 additions & 36 deletions

File tree

‎More/EAV/Attribute.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ class Attribute implements ValueAccessInterface
1010
/**
1111
* @var array|Value[]|ValueInterface[]
1212
*/
13-
private $values = [];
13+
private $values = array();
1414

1515
/**
1616
* @var string

‎More/EAV/Entity.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ class Entity implements ValueAccessInterface
1010
/**
1111
* @var array|Value[]|ValueInterface[]
1212
*/
13-
private $values = [];
13+
private $values = array();
1414

1515
/**
1616
* @var string

‎More/EAV/Tests/AttributeTest.php‎

Lines changed: 19 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,15 @@ public function testAddValue()
3636
$attribute = new Attribute();
3737
$attribute->setName('Color');
3838

39-
$values[] = (new Value($attribute))->setName('Silver');
40-
$values[] = (new Value($attribute))->setName('Gold');
41-
$values[] = (new Value($attribute))->setName('Space Grey');
39+
$colorSilver = new Value($attribute);
40+
$colorSilver->setName('Silver');
41+
$values[] = $colorSilver;
42+
$colorGold = new Value($attribute);
43+
$colorGold->setName('Gold');
44+
$values[] = $colorGold;
45+
$colorSpaceGrey = new Value($attribute);
46+
$colorSpaceGrey->setName('Space Grey');
47+
$values[] = $colorSpaceGrey;
4248

4349
$this->assertEquals($values, $attribute->getValues());
4450
}
@@ -48,14 +54,20 @@ public function testAddValue()
4854
*/
4955
public function testRemoveValue()
5056
{
51-
$values = [];
57+
$values = array();
5258

5359
$attribute = new Attribute();
5460
$attribute->setName('Color');
5561

56-
$values[] = (new Value($attribute))->setName('Silver');
57-
$values[] = (new Value($attribute))->setName('Gold');
58-
$values[] = (new Value($attribute))->setName('Space Grey');
62+
$colorSilver = new Value($attribute);
63+
$colorSilver->setName('Silver');
64+
$values[] = $colorSilver;
65+
$colorGold = new Value($attribute);
66+
$colorGold->setName('Gold');
67+
$values[] = $colorGold;
68+
$colorSpaceGrey = new Value($attribute);
69+
$colorSpaceGrey->setName('Space Grey');
70+
$values[] = $colorSpaceGrey;
5971

6072
$randomIndex = array_rand($values);
6173
$attribute->removeValue($values[$randomIndex]);

‎More/EAV/Tests/EntityTest.php‎

Lines changed: 40 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -71,62 +71,75 @@ public function testRemoveValue($name, array $values)
7171
public function valueProvider()
7272
{
7373
// color attribute
74-
$color = (new Attribute())->setName('Color');
74+
$color = new Attribute();
75+
$color->setName('Color');
7576
// color values
76-
$colorSilver = (new Value($color))->setName('Silver');
77-
$colorGold = (new Value($color))->setName('Gold');
78-
$colorSpaceGrey = (new Value($color))->setName('Space Grey');
77+
$colorSilver = new Value($color);
78+
$colorSilver->setName('Silver');
79+
$colorGold = new Value($color);
80+
$colorGold->setName('Gold');
81+
$colorSpaceGrey = new Value($color);
82+
$colorSpaceGrey->setName('Space Grey');
7983

8084
// memory attribute
81-
$memory = (new Attribute())->setName('Memory');
85+
$memory = new Attribute();
86+
$memory->setName('Memory');
8287
// memory values
83-
$memory4Gb = (new Value($memory))->setName('4GB');
84-
$memory8Gb = (new Value($memory))->setName('8GB');
85-
$memory16Gb = (new Value($memory))->setName('16GB');
88+
$memory4Gb = new Value($memory);
89+
$memory4Gb->setName('4GB');
90+
$memory8Gb = new Value($memory);
91+
$memory8Gb->setName('8GB');
92+
$memory16Gb = new Value($memory);
93+
$memory16Gb->setName('16GB');
8694

8795
// storage attribute
88-
$storage = (new Attribute())->setName('Storage');
96+
$storage = new Attribute();
97+
$storage->setName('Storage');
8998
// storage values
90-
$storage128Gb = (new Value($storage))->setName('128GB');
91-
$storage256Gb = (new Value($storage))->setName('256GB');
92-
$storage512Gb = (new Value($storage))->setName('512GB');
93-
$storage1Tb = (new Value($storage))->setName('1TB');
99+
$storage128Gb = new Value($storage);
100+
$storage128Gb->setName('128GB');
101+
$storage256Gb = new Value($storage);
102+
$storage256Gb->setName('256GB');
103+
$storage512Gb = new Value($storage);
104+
$storage512Gb->setName('512GB');
105+
$storage1Tb = new Value($storage);
106+
$storage1Tb->setName('1TB');
94107

95-
return [
96-
[
108+
return array(
109+
array(
97110
'MacBook',
98-
[
111+
array(
99112
$colorSilver,
100113
$colorGold,
101114
$colorSpaceGrey,
102115
$memory8Gb,
103116
$storage256Gb,
104117
$storage512Gb,
105-
],
106-
],
107-
[
118+
),
119+
),
120+
array(
108121
'MacBook Air',
109-
[
122+
array(
110123
$colorSilver,
111124
$memory4Gb,
112125
$memory8Gb,
113126
$storage128Gb,
114127
$storage256Gb,
115128
$storage512Gb,
116-
],
117-
],
118-
[
129+
),
130+
),
131+
array(
119132
'MacBook Pro',
120-
[
133+
array(
121134
$colorSilver,
122135
$memory8Gb,
123136
$memory16Gb,
124137
$storage128Gb,
125138
$storage256Gb,
126139
$storage512Gb,
127140
$storage1Tb,
128-
],
129-
],
130-
];
141+
),
142+
),
143+
);
131144
}
132145
}

0 commit comments

Comments
 (0)
Back | FazBrowse Home | New Git URL