make PATH.resolve return an error result on paths with '' portions · JavaScriptIOT/emscripten@59932ef · GitHub

JavaScriptIOT / emscripten Public

forked from emscripten-core/emscripten

• Notifications You must be signed in to change notification settings
• Fork 0
• Star 0

• Code
• Pull requests
• Actions
• Projects
• Wiki
• Security and quality
• Insights

Additional navigation options

Commit 59932ef

Browse filesBrowse the repository at this point in the historyBrowse files

kripken

committed

make PATH.resolve return an error result on paths with '' portions

1 parent 53726c8 commit 59932ef
Copy full SHA for 59932ef

3 files changed

+1-13Lines changed: 1 addition & 13 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src
  • library_path.js
• tests/filesystem
  • output.txt
  • src.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/library_path.js‎

Copy file name to clipboardExpand all lines: src/library_path.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -85,7 +85,7 @@ mergeInto(LibraryManager.library, {
85	85	if (typeof path !== 'string') {
86	86	throw new TypeError('Arguments to path.resolve must be strings');
87	87	} else if (!path) {
88		- continue;
	88	+ return ''; // an invalid portion invalidates the whole thing
89	89	}
90	90	resolvedPath = path + '/' + resolvedPath;
91	91	resolvedAbsolute = path.charAt(0) === '/';

Collapse file

‎tests/filesystem/output.txt‎

Copy file name to clipboardExpand all lines: tests/filesystem/output.txt

-11Lines changed: 0 additions & 11 deletions

Original file line number	Diff line number	Diff line change
@@ -1,14 +1,3 @@
1		-
2		- isRoot: false
3		- exists: true
4		- error: 0
5		- path: /abc
6		- name: abc
7		- object.contents: ["123","456","deviceA","localLink","rootLink","relativeLink"]
8		- parentExists: true
9		- parentPath: /
10		- parentObject.contents: ["tmp","dev","forbidden","abc","def"]
11		-
12	1	/
13	2	isRoot: true
14	3	exists: true

Collapse file

‎tests/filesystem/src.js‎

Copy file name to clipboardExpand all lines: tests/filesystem/src.js

-1Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -31,7 +31,6 @@ function explore(path) {
31	31	}
32	32
33	33	FS.currentPath = '/abc';
34		- explore('');
35	34	explore('/');
36	35	explore('.');
37	36	explore('..');

0 commit comments

Comments

0 (0)