| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
3 files changed
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1,6 +1,6 @@ | |||
| 1 | 1 | # Site settings | |
| 2 | 2 | title: Tableau Document API | |
| 3 | - email: jdominguez@tableau.com | ||
| 3 | + email: github@tableau.com | ||
| 4 | 4 | description: Programmatically update your Tableau workbooks and data sources. | |
| 5 | 5 | baseurl: "/document-api-python" | |
| 6 | 6 | permalinks: pretty | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -17,7 +17,7 @@ | |||
| 17 | 17 | <div class="content .col-xs-12 .col-sm-8 .col-md-9"> | |
| 18 | 18 | <h1>{{ page.title }}</h1> | |
| 19 | 19 | <div class="edit-container"> | |
| 20 | - <a href="https://github.com/tableau/document-api-python/edit/master/{{ page.path }}" class="edit-links"><span class="glyphicon glyphicon-pencil"></span> Edit this page</a> | ||
| 20 | + <a href="https://github.com/tableau/document-api-python/edit/master/docs/{{ page.path }}" class="edit-links"><span class="glyphicon glyphicon-pencil"></span> Edit this page</a> | ||
| 21 | 21 | | |
| 22 | 22 | <a href="https://github.com/tableau/document-api-python/issues" class="edit-links"><span class="glyphicon glyphicon-flag"></span> Submit an issue</a> | |
| 23 | 23 | </div> | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -3,51 +3,66 @@ title: Developer Guide | |||
| 3 | 3 | layout: docs | |
| 4 | 4 | --- | |
| 5 | 5 | ||
| 6 | - ### Making your first patch | ||
| 6 | + ## Submitting your first patch | ||
| 7 | 7 | ||
| 8 | - 1. Make sure you've signed the CLA | ||
| 8 | + 1. Make sure you have [signed the CLA](http://tableau.github.io/#contributor-license-agreement-cla) | ||
| 9 | 9 | ||
| 10 | - 1. Clone the repo | ||
| 10 | + 1. Fork the repository. | ||
| 11 | + | ||
| 12 | + We follow the "Fork and Pull" model as described [here](https://help.github.com/articles/about-collaborative-development-models/). | ||
| 13 | + | ||
| 14 | + 1. Clone your fork: | ||
| 11 | 15 | ||
| 12 | 16 | ```shell | |
| 13 | - git clone http://github.com/tableau/document-api-python | ||
| 17 | + git clone http://github.com/<your_username>/document-api-python | ||
| 14 | 18 | ``` | |
| 15 | 19 | ||
| 16 | - 1. Run the tests to make sure everything is peachy | ||
| 20 | + 1. Run the tests to make sure everything is peachy: | ||
| 17 | 21 | ||
| 18 | 22 | ```shell | |
| 19 | 23 | python setup.py test | |
| 20 | 24 | ``` | |
| 21 | 25 | ||
| 22 | 26 | 1. Set up the feature, fix, or documentation branch. | |
| 23 | 27 | ||
| 24 | - It is recommended to use the format [issue#]-[type]-[description] (e.g. 13-fix-connection-bug) | ||
| 28 | + It is recommended to use the format issue#-type-description (e.g. 13-fix-connection-bug) like so: | ||
| 25 | 29 | ||
| 26 | 30 | ```shell | |
| 27 | 31 | git checkout -b 13-feature-new-stuff | |
| 28 | 32 | ``` | |
| 29 | 33 | ||
| 30 | - 1. Code and Commit! | ||
| 34 | + 1. Code and commit! | ||
| 35 | + | ||
| 36 | + Here's a quick checklist for ensuring a good pull request: | ||
| 37 | + | ||
| 38 | + - Only touch the minimal amount of files possible while still accomplishing the goal. | ||
| 39 | + - Ensure all indentation is done as 4-spaces and your editor is set to unix line endings. | ||
| 40 | + - The code matches PEP8 style guides. If you cloned the repo you can run `pycodestyle .` | ||
| 41 | + - Keep commit messages clean and descriptive. | ||
| 42 | + If the PR is accepted it will get 'Squashed' into a single commit before merging, the commit messages will be used to generate the Merge commit message. | ||
| 31 | 43 | ||
| 32 | - Here's a quick checklist for ensuring a good diff: | ||
| 44 | + 1. Add tests. | ||
| 33 | 45 | ||
| 34 | - - The diff touches the minimal amount of files possible while still fufilling the purpose of the diff | ||
| 35 | - - The diff uses Unix line endings | ||
| 36 | - - The diff adheres to our PEP8 style guides. If you've cloned the repo you can run `pycodestyle .` | ||
| 46 | + All of our tests live under the `test/` folder in the repository. | ||
| 47 | + We use `unittest` and the built-in test runner `python setup.py test`. | ||
| 48 | + If a test needs a static file, like a twb/twbx, it should live under `test/assets/` | ||
| 37 | 49 | ||
| 38 | - 1. Add Tests | ||
| 50 | + 1. Update the documentation. | ||
| 39 | 51 | ||
| 40 | - 1. Update Documentation | ||
| 52 | + Our documentation is written in markdown and built with Jekyll on Github Pages. All of the documentation source files can be found in `docs/docs`. | ||
| 41 | 53 | ||
| 42 | - Our documentation is written in markdown and built with [Mkdocs](http://www.mkdocs.org). More information on how to update and build the docs can be found [here](#updating-documentation) | ||
| 54 | + When adding a new feature or improving existing functionality we may ask that you update the documentation along with your code. | ||
| 55 | + | ||
| 56 | + If you are just making a PR for documentation updates (adding new docs, fixing typos, improving wording) the easiest method is to use the built in `Edit this file` in the Github UI | ||
| 43 | 57 | ||
| 44 | - 1. Run the tests again and make sure they pass! | ||
| 58 | + 1. Submit to your fork. | ||
| 45 | 59 | ||
| 46 | - 1. Submit to your fork | ||
| 60 | + 1. Make a PR as described [here](https://help.github.com/articles/creating-a-pull-request-from-a-fork/) against the 'development' branch. | ||
| 47 | 61 | ||
| 48 | - 1. Submit a PR | ||
| 62 | + 1. Wait for a review and address any feedback. | ||
| 63 | + While we try and stay on top of all issues and PRs it might take a few days for someone to respond. Politely pinging the PR after a few days with no response is OK, we'll try and respond with a timeline as soon as we are able. | ||
| 49 | 64 | ||
| 50 | - 1. Wait for a review, and address any feedback. | ||
| 65 | + 1. That's it! When the PR has received :rocket:'s from members of the core team they will merge the PR | ||
| 51 | 66 | ||
| 52 | 67 | <!-- | |
| 53 | 68 | ### Updating Documentation | |
| Back | FazBrowse Home | New Git URL |
0 commit comments