merge: reduce upper & lower & add export default (#960) · Jerad551/JavaScript@27ae62e · GitHub

Jerad551 / JavaScript Public

forked from TheAlgorithms/JavaScript

• Notifications You must be signed in to change notification settings
• Fork 0
• Star 1

• Code
• Pull requests
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 27ae62e

Browse filesBrowse the repository at this point in the historyBrowse files

fahimfaisaal

authored

merge: reduce upper & lower & add export default (TheAlgorithms#960)

1 parent 3b9af46 commit 27ae62e
Copy full SHA for 27ae62e

4 files changed

+9-17Lines changed: 9 additions & 17 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• String
  • Lower.js
  • Upper.js
  • test
    • Lower.test.js
    • Upper.test.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎String/Lower.js‎

Copy file name to clipboardExpand all lines: String/Lower.js

+4-7Lines changed: 4 additions & 7 deletions

Original file line number	Diff line number	Diff line change
@@ -12,12 +12,9 @@ const lower = (str) => {
12	12	throw new TypeError('Invalid Input Type')
13	13	}
14	14
15		- return str
16		- .replace(/[A-Z]/g, (_, indexOfUpperChar) => {
17		- const asciiCode = str.charCodeAt(indexOfUpperChar)
18		-
19		- return String.fromCharCode(asciiCode + 32)
20		- })
	15	+ return str.replace(
	16	+ /[A-Z]/g, (char) => String.fromCharCode(char.charCodeAt() + 32)
	17	+ )
21	18	}
22	19
23		- export { lower }
	20	+ export default lower

Collapse file

‎String/Upper.js‎

Copy file name to clipboardExpand all lines: String/Upper.js

+2-7Lines changed: 2 additions & 7 deletions

Original file line number	Diff line number	Diff line change
@@ -12,13 +12,8 @@ const upper = (str) => {
12	12	}
13	13
14	14	return str.replace(
15		- /[a-z]/g,
16		- (_, indexOfLowerChar) => {
17		- const asciiCode = str.charCodeAt(indexOfLowerChar)
18		-
19		- return String.fromCharCode(asciiCode - 32)
20		- }
	15	+ /[a-z]/g, (char) => String.fromCharCode(char.charCodeAt() - 32)
21	16	)
22	17	}
23	18
24		- export { upper }
	19	+ export default upper

Collapse file

‎String/test/Lower.test.js‎

Copy file name to clipboardExpand all lines: String/test/Lower.test.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -1,4 +1,4 @@
1		- import { lower } from '../Lower'
	1	+ import lower from '../Lower'
2	2
3	3	describe('Testing the Lower function', () => {
4	4	it('Test 1: Check by invalid type', () => {

Collapse file

‎String/test/Upper.test.js‎

Copy file name to clipboardExpand all lines: String/test/Upper.test.js

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -1,6 +1,6 @@
1		- import { upper } from '../Upper'
	1	+ import upper from '../Upper'
2	2
3		- describe('Upper', () => {
	3	+ describe('Testing the Upper function', () => {
4	4	it('return uppercase strings', () => {
5	5	expect(upper('hello')).toBe('HELLO')
6	6	expect(upper('WORLD')).toBe('WORLD')

0 commit comments

Comments

0 (0)