Raise TypeError when an invalid argument is passed for email, closes … · JoshData/python-email-validator@e943a0f · GitHub

JoshData / python-email-validator Public

• Notifications You must be signed in to change notification settings
• Fork 139
• Star 1.4k

• Code
• Issues 11
• Pull requests 4
• Actions
• Projects
• Wiki
• Security and quality
• Insights

Additional navigation options

Commit e943a0f

Browse filesBrowse the repository at this point in the historyBrowse files

JoshData

committed

Raise TypeError when an invalid argument is passed for email, closes #155

1 parent f90d256 commit e943a0f
Copy full SHA for e943a0f

1 file changed

+8-4Lines changed: 8 additions & 4 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• email_validator
  • validate_email.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎email_validator/validate_email.py‎

Copy file name to clipboardExpand all lines: email_validator/validate_email.py

+8-4Lines changed: 8 additions & 4 deletions

Original file line number	Diff line number	Diff line change
@@ -59,14 +59,18 @@ def validate_email(
59	59	if timeout is None and dns_resolver is None:
60	60	timeout = DEFAULT_TIMEOUT
61	61
62		- # Allow email to be a str or bytes instance. If bytes,
63		- # it must be ASCII because that's how the bytes work
64		- # on the wire with SMTP.
65		- if not isinstance(email, str):
	62	+ if isinstance(email, str):
	63	+ pass
	64	+ elif isinstance(email, bytes):
	65	+ # Allow email to be a bytes instance as if it is what
	66	+ # will be transmitted on the wire. But assume SMTPUTF8
	67	+ # is unavailable, so it must be ASCII.
66	68	try:
67	69	email = email.decode("ascii")
68	70	except ValueError as e:
69	71	raise EmailSyntaxError("The email address is not valid ASCII.") from e
	72	+ else:
	73	+ raise TypeError("email must be str or bytes")
70	74
71	75	# Split the address into the display name (or None), the local part
72	76	# (before the @-sign), and the domain part (after the @-sign).

0 commit comments

Comments

0 (0)