FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Allow untyped imports · Pull Request #11889 · microsoft/TypeScript · GitHub

/ TypeScript Public

Allow untyped imports - #11889

Merged
2 commits merged into
masterfrom
untyped_imports
Oct 27, 2016
ConversationCommits (2)ChecksFiles changed
Merged

Allow untyped imports#11889
2 commits merged into
masterfrom
untyped_imports

Conversation

Deleted user (ghost) commented Oct 27, 2016 •
edited by ghost
Loading

Copy link
Copy Markdown

Fixes #11106
Replaces #11446
Made easier by #11704. No longer has to touch moduleNameResolver.ts.

ghost mentioned this pull request Oct 27, 2016
Closed
ghost force-pushed the untyped_imports branch from 3534494 to c81fec6 Compare October 27, 2016 14:29
ghost force-pushed the untyped_imports branch from c81fec6 to 4937d9c Compare October 27, 2016 15:54
Mohamed Hegazy (mhegazy) approved these changes Oct 27, 2016
View reviewed changes

Mohamed Hegazy (mhegazy) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

With changes to the error message

Comment thread src/compiler/diagnosticMessages.json Outdated
"category": "Error",
"code": 6143
},
"A package for '{0}' was found at '{1}', but is untyped. Because '--noImplicitAny' is enabled, this package must have a declaration.": {

Mohamed Hegazy (mhegazy) Oct 27, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

how about something more consistent with the rest of the the --noImplicitAny error message, e.g.: Could not find a declaration file for module '{0}'. All imports implicitly have type 'any'.

Deleted user (ghost) Oct 27, 2016

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

How about: "Could not find a declaration file for module '{0}'. '{1}' implicitly has an 'any' type."

Mohamed Hegazy (mhegazy) Oct 27, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

👍

Comment thread src/compiler/diagnosticMessages.json Outdated
},
"A package for '{0}' was found at '{1}', but is untyped. Because '--noImplicitAny' is enabled, this package must have a declaration.": {
"category": "Error",
"code": 6144

Mohamed Hegazy (mhegazy) Oct 27, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

make this error code in the 7000 along with the other --noImplicitAnyErrors

ghost merged commit a143f97 into master Oct 27, 2016
ghost deleted the untyped_imports branch October 27, 2016 18:32
Steve Kellock (skellock) mentioned this pull request Nov 13, 2016
Closed
Mario Ranftl (majodev) mentioned this pull request Jan 23, 2017
Closed
Microsoft (microsoft) locked and limited conversation to collaborators Jun 19, 2018
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL