Missing property fix - #14097
Merged
Arthur Ozga (aozgaa) merged 8 commits intoFeb 16, 2017
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Comment thread
src/services/codefixes/fixAddMissingMember.ts
Outdated
| const binaryExpression = token.parent.parent as BinaryExpression; | ||
|
|
||
| const checker = context.program.getTypeChecker(); | ||
| const widenedType = checker.getBaseTypeOfLiteralType(checker.getTypeAtLocation(binaryExpression.right)); |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
you also want to widen it. i.e. null => any
Sorry, something went wrong.
Mohamed Hegazy (mhegazy)
approved these changes
Feb 16, 2017
Mohamed Hegazy (mhegazy)
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks good. just add the getWidenedType call
Sorry, something went wrong.
Daniel Rosenwasser (DanielRosenwasser)
requested changes
Feb 16, 2017
Comment thread
src/services/codefixes/fixAddMissingMember.ts
Outdated
| }] | ||
| }, | ||
| { | ||
| description: formatStringFromArgs(getLocaleSpecificMessage(Diagnostics.Add_index_accessor_for_missing_property_0), [token.getText()]), |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
- "index accessor" -> "index signature"
- You either need a test for this fix, or you should get rid of it.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
changed and test added
Sorry, something went wrong.
Mohamed Hegazy (mhegazy)
approved these changes
Feb 16, 2017
Copy link
Copy Markdown
Contributor
|
Arthur Ozga (@aozgaa) after merging in master please port this to release-2.2 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #13071.
Note that there is considerably more work to do for stubbing out missing methods if we want to do any type inference on the parameters. There are additionally issues with inferring type parameters for the stubbed method from its type arguments.
Thoughts Mohamed Hegazy (@mhegazy) Bill Ticehurst (@billti) Daniel Rosenwasser (@DanielRosenwasser) ?