fixCannotFindModule: Special handling for node core modules like "fs" - #23807
Merged
2 commits merged intoMay 1, 2018
Merged
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
ghost
requested review from
Daniel Rosenwasser (DanielRosenwasser) and
Mohamed Hegazy (mhegazy)
May 1, 2018 19:56
Mohamed Hegazy (mhegazy)
approved these changes
May 1, 2018
Comment thread
src/services/codefixes/fixCannotFindModule.ts
| function getTypesPackageNameToInstall(host: LanguageServiceHost, sourceFile: SourceFile, pos: number, diagCode: number): string | undefined { | ||
| const moduleName = cast(getTokenAtPosition(sourceFile, pos, /*includeJsDocComment*/ false), isStringLiteral).text; | ||
| const { packageName } = getPackageName(moduleName); | ||
| return host.isKnownTypesPackageName(packageName) ? getTypesPackageName(packageName) : undefined; |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Given that we arent using getTypesPackageName remove it ?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
ok i see you moved that later, but dont cant you just make it @types/node here and getTypesPackageName(packageName) in else branch instead ?
Sorry, something went wrong.
Copy link
Copy Markdown
Author
There was a problem hiding this comment.
Done
Sorry, something went wrong.
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23224