| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
TypeScript Bot (@typescript-bot) test this |
Sorry, something went wrong.
|
Heya Ron Buckton (@rbuckton), I've started to run the Definitely Typed test suite on this PR at 645853a. You can monitor the build here. It should now contribute to this PR's status checks. |
Sorry, something went wrong.
|
Heya Ron Buckton (@rbuckton), I've started to run the extended test suite on this PR at 645853a. You can monitor the build here. It should now contribute to this PR's status checks. |
Sorry, something went wrong.
|
TypeScript Bot (@typescript-bot) perf test |
Sorry, something went wrong.
|
Heya Ron Buckton (@rbuckton), I've started to run the perf test suite on this PR at c712918. You can monitor the build here. It should now contribute to this PR's status checks. |
Sorry, something went wrong.
|
Pardon the dust, tinkering with the on-demand benchmark script to not generate a massive wall of text when posting the results. |
Sorry, something went wrong.
Sorry, something went wrong.
|
Ryan Cavanaugh (@RyanCavanaugh): I've added tests and verified that this does indeed fix those issues. |
Sorry, something went wrong.
|
Anders Hejlsberg (@ahejlsberg): Can you take a look? |
Sorry, something went wrong.
There was a problem hiding this comment.
I'd inline the constant instead of shouting all caps.
Sorry, something went wrong.
|
Hmm, why doesn't #12052 seem to link back to this issue? Oh, does locking an issue actually prevent it from getting new "@somebody mentioned this" links? That's too bad... it becomes much harder to follow up on these longstanding issues. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
This PR effects how we relate a source "Object" type to a target union type when:
For example, today if we were to change IteratorResult to be a discriminated union, the following example would no longer compile:
With this change, we will perform the following steps after all other relationship checks fail:
If 'source' is an Object type and 'target' is a Union type with discriminant properties:
This means that now, for the example above, we perform the following steps:
Further examples can be found in assignmentCompatWithDiscriminatedUnion.ts
Related: #2983
Fixes: #14865
Fixes: #30871
Fixes: #30170
Fixes: #12052
Fixes: #18421
Fixes: #15907
Fixes: #20889