Hi Arthur Ozga (@aozgaa), I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Arthur Ozga). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

👍

Thoughs Mohamed Hegazy (@mhegazy), Anders Hejlsberg (@ahejlsberg) ?

There are apparently some issues with the build - you probably need to fix up baselines that don't agree with the merge.

Daniel Rosenwasser (@DanielRosenwasser) The error codes needed to be changed as part of merging the upstream fixes and this broke some of the baselines. No other errors occurred. They've been added now :).

👍

👍

This should be added to the Roadmap and What's New In TypeScript page.

How does this work with imported module?

When I have like this application.ts

import * as amqp from 'amqplib';

// I want to merge declaration with `interface amqp.ExchangeOptions`
interface ExchangeOptions {
  'x-recent-history-length' : number;
}

interface amqp.ExchangeOptions {
  'x-recent-history-length' : number;
}

Which one should work?

Neither one of those would work here. You'd need to do the following:

declare module 'amqplib' {
    interface ExchangeOptions {
       'x-recent-history-length' : number;
    }
}

Thanks!

Jason Freeman (@JsonFreeman) Is there an equivalent for external modules?

Asad Saeeduddin (@masaeedu) please see #6213

This doesn't appear to be possible but feels like it should:

interface Foo {
    readonly name: string
}

class Foo {
    constructor(name: string) {
        this.name = name; //error
    }    
}

Nicholas Bransby-Williams (@nbransby) thanks, I'll open an issue for you.