| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Conflicts: src/compiler/diagnosticInformationMap.generated.ts src/compiler/diagnosticMessages.json
Still need to implement some error recovery and add tests.
These tests still need to be fixed.
There was a problem hiding this comment.
Explain why this is correct. I believe it's because we rewrite this to string addition, and string addition allows the other side to be of any type. So we don't need to check for things like void types, etc. But it would be good to comment this bit.
Sorry, something went wrong.
|
"Do we want to accept simple (non-substitution) templates in places we accept string literals (i.e. module names, overloading on string constants, etc.)? On one hand, it would seem more consistent with the rest of our language, but ECMAScript 6 does not accept them in property names." I would say no. I'm not sure we have a reason to be more lenient than ES6. |
Sorry, something went wrong.
|
Jason Freeman (@JsonFreeman) I agree; what about indexing? |
Sorry, something went wrong.
|
I think we can type an index expression with literal, yes. |
Sorry, something went wrong.
Conflicts: src/compiler/checker.ts src/services/services.ts
Conflicts: src/compiler/diagnosticInformationMap.generated.ts src/compiler/diagnosticMessages.json src/compiler/types.ts src/services/utilities.ts
Support for ES6 Templates
|
Ryan Cavanaugh (@RyanCavanaugh) excuse me. please add es6 label to this issue. |
Sorry, something went wrong.
|
I just noticed that this ES6 feature is still a proposal, so why implement it already? Not that it isn't great and useful, just wondering why focusing on things that are still status: Draft on ES6 specs. I guess you have your reasons, just wonder what they are ;) |
Sorry, something went wrong.
|
It's actually pretty much nailed down, and it's very unlikely that it will be removed/modified drastically. If anything does change, we'll be very mindful in addressing that. =) |
Sorry, something went wrong.
|
Ok, nice then, it's a nice feature btw, looking forward for 1.4. :) |
Sorry, something went wrong.
|
Hi there, I realize that this is on the Roadmap for 1.4. I'm curious though if we might see it sooner as perhaps an experimental option. My team and I would certainly love to start using this sooner rather than later to clean up our code :-) Cheers! |
Sorry, something went wrong.
|
Hey Topher Fangio (@topherfangio), glad to hear you're enthusiastic about this feature. If you're dying to try it out, you can clone our repo and use our release-1.4 branch, but 1.4 is largely on the horizon, just be patient. =) |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
This pull request is meant to add support for ECMAScript 6 templates and address suggestion #13.
Right now this branch supports:
Things that will be done in a separate commit:
Questions worth asking: