[FEA] Remove `FutureWarning`s from Python tests · Issue #10363 · NVIDIA/cudf · GitHub

This is a meta-issue as part of #9999. Here, I catalog the current list of test files that raise a FutureWarning.

The use of a FutureWarning indicates a deprecated API, mostly from cudf or pandas. We should explicitly catch or filter out these warnings, depending on the circumstances. Eventually we will be able to run pytest -W error::FutureWarning to catch any deprecated APIs being called by our tests, which may conceal a regression in the user API.

test_csv.py Fix warnings in test_csv.py. #10362
test_cuda_apply.py Fix warnings in test_cuda_apply, test_numerical, test_pickling, test_unaops. #10402
test_dataframe.py
test_groupby.py
test_index.py
test_indexing.py Fix warnings in test_indexing.py #12305
test_joining.py Fix warnings in test_joining.py #12304
test_multiindex.py Fix warnings in test_multiindex.py #12310
test_numerical.py Fix warnings in test_cuda_apply, test_numerical, test_pickling, test_unaops. #10402
test_orc.py
test_parquet.py (partial) [REVIEW] Fix some warnings in test_parquet.py #10416
test_pickling.py Fix warnings in test_cuda_apply, test_numerical, test_pickling, test_unaops. #10402
test_rolling.py Fix warnings in test_rolling #10405
test_stats.py Fix warnings in test_stats.py #12293
test_timedelta.py [REVIEW] Remove warnings in test_timedelta.py #10418
test_unaops.py Fix warnings in test_cuda_apply, test_numerical, test_pickling, test_unaops. #10402
Update tests to fail on FutureWarning: pytest -W error::FutureWarning

Fix warnings in test_cuda_apply, test_numerical, test_pickling, test_…

Fix warnings in `test_rolling` (#10405)

Fix some warnings in `test_parquet.py` (#10416)

Remove warnings in `test_timedelta.py` (#10418)

I traced down some unexpected behavior and it turns out to be an error in the Python docs. This comment explains what I found, for posterity/reference. cc: @galipremsagar

I tried to specify a warning filter pytest -W error::FutureWarning:cudf.* on the command line. This follows the guidelines for how to specify warning filters as action:message:category:module:line.

I expected that this would raise an error for any FutureWarning raised by the cudf module or its subpackages, by interpreting the cudf.* module string as a regular expression. However, we can't do this with -W, because the input strings for message and module are escaped and not interpreted as regular expressions when defined with -W or PYTHONWARNINGS. The docs indicate that the module string is always treated as a regular expression, but that is only true for warnings.filterwarnings and not the command line option -W or environment variable PYTHONWARNINGS. This problem in the docs was reported in https://bugs.python.org/issue42272 and fixed in python/cpython#23172.

The workaround for this is to define this in our pytest configuration, setup.cfg, with the following:

[tool:pytest]
filterwarnings = error::FutureWarning:cudf.*

References:

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

This issue has been labeled inactive-90d due to no recent activity in the past 90 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.