FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: WrappedValue.unwrap empty string behavior (#6900) · NativeScript/NativeScript@0482460 · GitHub

Commit 0482460

Browse files
authored andcommitted
fix: WrappedValue.unwrap empty string behavior (#6900)
1 parent 3c2c1d9 commit 0482460

2 files changed

Lines changed: 14 additions & 3 deletions

File tree

‎tests/app/data/observable-tests.ts‎

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -521,7 +521,18 @@ export function test_CorrectPropertyValueAfterUsingWrappedValue() {
521521

522522
testObservable.set("property1", wrappedArray);
523523

524-
TKUnit.assertEqual(testObservable.get("property1"), testArray, "WrappedValue is used only to execute property change logic and unwrapped value should be used as proeprty value.");
524+
TKUnit.assertEqual(testObservable.get("property1"), testArray, "WrappedValue is used only to execute property change logic and unwrapped value should be used as property value.");
525+
}
526+
527+
export function test_CorrectPropertyValueAfterUsingStringEmptyWrappedValue() {
528+
const emptyString = "";
529+
let testObservable = fromObject({ "property1": emptyString });
530+
531+
let wrappedEmptyString = WrappedValue.wrap(emptyString);
532+
533+
testObservable.set("property1", wrappedEmptyString);
534+
535+
TKUnit.assertEqual(testObservable.get("property1"), emptyString, "WrappedValue is used only to execute property change logic and unwrapped value should be used as property value.");
525536
}
526537

527538
export function test_NestedObservablesWithObservableArrayShouldNotCrash() {

‎tns-core-modules/data/observable/observable.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ export class WrappedValue implements WrappedValueDefinition {
1313
}
1414

1515
public static unwrap(value: any) {
16-
return (value && value.wrapped) ? value.wrapped : value;
16+
return (value instanceof WrappedValue) ? value.wrapped : value;
1717
}
1818

1919
public static wrap(value: any) {
@@ -249,4 +249,4 @@ export function fromObjectRecursive(source: any): Observable {
249249
let observable = new ObservableFromObject();
250250
addPropertiesFromObject(observable, source, true);
251251
return observable;
252-
}
252+
}

0 commit comments

Comments
 (0)

Back | FazBrowse Home | New Git URL