fix(android): nested frames on app suspend/resume (#6339) · NativeScript/NativeScript@0bf6dc2 · GitHub

NativeScript / NativeScript Public

• Notifications You must be signed in to change notification settings
• Fork 1.7k
• Star 25.7k

• Code
• Issues 773
• Pull requests 69
• Discussions
• Actions
• Projects
• Wiki
• Security and quality
• Insights

Additional navigation options

Commit 0bf6dc2

Browse filesBrowse the repository at this point in the historyBrowse files

manoldonev

authored

fix(android): nested frames on app suspend/resume (#6339)

1 parent 2e3c0a8 commit 0bf6dc2
Copy full SHA for 0bf6dc2

1 file changed

+11Lines changed: 11 additions & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• tns-core-modules/ui/frame
  • frame.android.ts

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎tns-core-modules/ui/frame/frame.android.ts‎

Copy file name to clipboardExpand all lines: tns-core-modules/ui/frame/frame.android.ts

+11Lines changed: 11 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -755,6 +755,17 @@ class FragmentCallbacksImplementation implements AndroidFragmentCallbacks {
755	755	if (traceEnabled()) {
756	756	traceWrite(`${fragment}.onDestroyView()`, traceCategories.NativeLifecycle);
757	757	}
	758	+
	759	+ // fixes 'java.lang.IllegalStateException: The specified child already has a parent. You must call removeView() on the child's parent first'.
	760	+ // on app resume in nested frame scenarios with support library version greater than 26.0.0
	761	+ const view = fragment.getView();
	762	+ if (view != null) {
	763	+ const viewParent = view.getParent();
	764	+ if (viewParent instanceof android.view.ViewGroup) {
	765	+ viewParent.removeView(view);
	766	+ }
	767	+ }
	768	+
758	769	superFunc.call(fragment);
759	770	}
760	771

0 commit comments

Comments

0 (0)