fix: issue where image elements could end up in invalid render state · NativeScript/NativeScript@13711cd · GitHub

NativeScript / NativeScript Public

• Notifications You must be signed in to change notification settings
• Fork 1.7k
• Star 25.7k

• Code
• Issues 781
• Pull requests 73
• Discussions
• Actions
• Projects
• Wiki
• Security and quality
• Insights

Additional navigation options

Commit 13711cd

Browse filesBrowse the repository at this point in the historyBrowse files

justindujardin

committed

fix: issue where image elements could end up in invalid render state

When loading an image from a remote resource, all the background properties are applied before the imageSource. When assigning borderRadius to an image, then later setting its imageSource would cause the image to be in a bad render state and completely disappear from the UI. This patch clones the backgroundInternal property after async assignment of the imageSource.

1 parent 2f0d3b0 commit 13711cd
Copy full SHA for 13711cd

1 file changed

+2Lines changed: 2 additions & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• tns-core-modules/ui/image
  • image-common.ts

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎tns-core-modules/ui/image/image-common.ts‎

Copy file name to clipboardExpand all lines: tns-core-modules/ui/image/image-common.ts

+2Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -78,6 +78,8 @@ export abstract class ImageBase extends View implements ImageDefinition {
78	78	fromUrl(value).then((r) => {
79	79	if (this["_url"] === value) {
80	80	this.imageSource = r;
	81	+ // Clone the backgroundStyle to correct (now invalid?) background state.
	82	+ this.style.backgroundInternal = this.style.backgroundInternal.clone();
81	83	this.isLoading = false;
82	84	}
83	85	});

0 commit comments

Comments

0 (0)