fix(ios-action-bar): enable NavigationButton text change on first nav… · NativeScript/NativeScript@14ce89f · GitHub

NativeScript / NativeScript Public

• Notifications You must be signed in to change notification settings
• Fork 1.7k
• Star 25.7k

• Code
• Issues 774
• Pull requests 70
• Discussions
• Actions
• Projects
• Wiki
• Security and quality
• Insights

Additional navigation options

Commit 14ce89f

Browse filesBrowse the repository at this point in the historyBrowse files

ADjenkov

authored and

ADjenkov

committed

fix(ios-action-bar): enable NavigationButton text change on first navigation

1 parent 4898c33 commit 14ce89f
Copy full SHA for 14ce89f

1 file changed

+9Lines changed: 9 additions & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• tns-core-modules/ui/frame
  • frame.ios.ts

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎tns-core-modules/ui/frame/frame.ios.ts‎

Copy file name to clipboardExpand all lines: tns-core-modules/ui/frame/frame.ios.ts

+9Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -13,6 +13,8 @@ import * as utils from "../../utils/utils";
13	13
14	14	export * from "./frame-common";
15	15
	16	+ const majorVersion = utils.ios.MajorVersion;
	17	+
16	18	const ENTRY = "_entry";
17	19	const NAV_DEPTH = "_navDepth";
18	20	const TRANSITION = "_transition";
@@ -86,6 +88,13 @@ export class Frame extends FrameBase {
86	88	backstackEntry[NAV_DEPTH] = navDepth;
87	89	viewController[ENTRY] = backstackEntry;
88	90
	91	+ if (majorVersion > 10) {
	92	+ // Reset back button title before pushing view controller to prevent
	93	+ // displaying default 'back' title (when NavigaitonButton custom title is set).
	94	+ let barButtonItem = UIBarButtonItem.alloc().initWithTitleStyleTargetAction("", UIBarButtonItemStyle.Plain, null, null);
	95	+ viewController.navigationItem.backBarButtonItem = barButtonItem;
	96	+ }
	97	+
89	98	// First navigation.
90	99	if (!this._currentEntry) {
91	100	// Update action-bar with disabled animations before the initial navigation.

0 commit comments

Comments

0 (0)