fix(android-connectivity): add ethernet connection type (#5670) · NativeScript/NativeScript@1536d15 · GitHub

NativeScript / NativeScript Public

• Notifications You must be signed in to change notification settings
• Fork 1.7k
• Star 25.7k

• Code
• Issues 773
• Pull requests 69
• Discussions
• Actions
• Projects
• Wiki
• Security and quality
• Insights

Additional navigation options

Commit 1536d15

Browse filesBrowse the repository at this point in the historyBrowse files

crowebird

authored and

manoldonev

committed

fix(android-connectivity): add ethernet connection type (#5670)

Add "ethernet" connection type to getConnectionType to correctly return a connection type when the type is "ethernet"

1 parent a616dbb commit 1536d15
Copy full SHA for 1536d15

2 files changed

+12-1Lines changed: 12 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• tns-core-modules/connectivity
  • connectivity.android.ts
  • connectivity.d.ts

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎tns-core-modules/connectivity/connectivity.android.ts‎

Copy file name to clipboardExpand all lines: tns-core-modules/connectivity/connectivity.android.ts

+6Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -4,10 +4,12 @@ export enum connectionType {
4	4	none = 0,
5	5	wifi = 1,
6	6	mobile = 2,
	7	+ ethernet = 3
7	8	}
8	9
9	10	const wifi = "wifi";
10	11	const mobile = "mobile";
	12	+ const ethernet = "ethernet";
11	13
12	14	// Get Connection Type
13	15	function getConnectivityManager(): android.net.ConnectivityManager {
@@ -37,6 +39,10 @@ export function getConnectionType(): number {
37	39	if (type.indexOf(mobile) !== -1){
38	40	return connectionType.mobile;
39	41	}
	42	+
	43	+ if (type.indexOf(ethernet) !== -1){
	44	+ return connectionType.ethernet;
	45	+ }
40	46
41	47	return connectionType.none;
42	48	}

Collapse file

‎tns-core-modules/connectivity/connectivity.d.ts‎

Copy file name to clipboardExpand all lines: tns-core-modules/connectivity/connectivity.d.ts

+6-1Lines changed: 6 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -27,7 +27,12 @@ export enum connectionType {
27	27	/**
28	28	* Denotes a mobile connection, i.e. cellular network or WAN.
29	29	*/
30		- mobile = 2
	30	+ mobile = 2,
	31	+
	32	+ /**
	33	+ * Denotes an ethernet connection
	34	+ */
	35	+ ethernet = 3
31	36	}
32	37
33	38	/**

0 commit comments

Comments

0 (0)