fix: call onNavigatingFrom event only if it exists (#6773) · NativeScript/NativeScript@19dfd16 · GitHub

NativeScript / NativeScript Public

• Notifications You must be signed in to change notification settings
• Fork 1.7k
• Star 25.7k

• Code
• Issues 773
• Pull requests 69
• Discussions
• Actions
• Projects
• Wiki
• Security and quality
• Insights

Additional navigation options

Commit 19dfd16

Browse filesBrowse the repository at this point in the historyBrowse files

grgur

authored and

manoldonev

committed

fix: call onNavigatingFrom event only if it exists (#6773)

I ran into an issue where `owner.onNavigatingFrom` didn't exist when rendering a view was blocked by the biometric scanner and then user hit the back button to navigate back. This code simply adds a check to see if `onNavigatingFrom` exists on the owner

1 parent 25f4b56 commit 19dfd16
Copy full SHA for 19dfd16

1 file changed

+1-1Lines changed: 1 addition & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• tns-core-modules/ui/page
  • page.ios.ts

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎tns-core-modules/ui/page/page.ios.ts‎

Copy file name to clipboardExpand all lines: tns-core-modules/ui/page/page.ios.ts

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -177,7 +177,7 @@ class UIViewControllerImpl extends UIViewController {
177	177	// or because we are closing a modal page,
178	178	// or because we are in tab and another controller is selected.
179	179	const tab = this.tabBarController;
180		- if (!owner._presentedViewController && !this.presentingViewController && frame && frame.currentPage === owner) {
	180	+ if (owner.onNavigatingFrom && !owner._presentedViewController && !this.presentingViewController && frame && frame.currentPage === owner) {
181	181	const willSelectViewController = tab && (<any>tab)._willSelectViewController;
182	182	if (!willSelectViewController
183	183	|| willSelectViewController === tab.selectedViewController) {

0 commit comments

Comments

0 (0)