fix(android/platform): reinitialise screen metrics on orientation cha… · NativeScript/NativeScript@2ee1d7d · GitHub

NativeScript / NativeScript Public

• Notifications You must be signed in to change notification settings
• Fork 1.7k
• Star 25.7k

• Code
• Issues 775
• Pull requests 73
• Discussions
• Actions
• Projects
• Wiki
• Security and quality
• Insights

Additional navigation options

Commit 2ee1d7d

Browse filesBrowse the repository at this point in the historyBrowse files

PeterStaev

authored and

Alexander Vakrilov

committed

fix(android/platform): reinitialise screen metrics on orientation change (#6164)

* fix(android/platform): reinitialise screen metrics on orientation change * fix(android/platform): reinitialise screen metrics on orientation change

1 parent ec24c5a commit 2ee1d7d
Copy full SHA for 2ee1d7d

1 file changed

+4-3Lines changed: 4 additions & 3 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• tns-core-modules/platform
  • platform.android.ts

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎tns-core-modules/platform/platform.android.ts‎

Copy file name to clipboardExpand all lines: tns-core-modules/platform/platform.android.ts

+4-3Lines changed: 4 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -101,8 +101,8 @@ class Device implements DeviceDefinition {
101	101
102	102	class MainScreen implements ScreenMetricsDefinition {
103	103	private _metrics: android.util.DisplayMetrics;
104		-
105		- private cssChanged(args: appModule.CssChangedEventData): void {
	104	+
	105	+ private reinitMetrics(): void {
106	106	if (!this._metrics) {
107	107	this._metrics = new android.util.DisplayMetrics();
108	108	}
@@ -117,7 +117,8 @@ class MainScreen implements ScreenMetricsDefinition {
117	117	private get metrics(): android.util.DisplayMetrics {
118	118	if (!this._metrics) {
119	119	// NOTE: This will be memory leak but we MainScreen is singleton
120		- appModule.on("cssChanged", this.cssChanged, this);
	120	+ appModule.on("cssChanged", this.reinitMetrics, this);
	121	+ appModule.on(appModule.orientationChangedEvent, this.reinitMetrics, this);
121	122
122	123	this._metrics = new android.util.DisplayMetrics();
123	124	this.initMetrics();

0 commit comments

Comments

0 (0)