Commit 324fdce
* fix(action-bar): #5743 navController may be null
From my own Crashlytics:
`stderr: file:///app/vendor.js:1:860568: JS ERROR TypeError: null is not an object (evaluating 'a.viewControllers')`
```
file:///app/vendor.js:1:860489
var l,p=a.viewControllers.indexOfObject(n);if(p>0&&p<a.viewControllers.count&&(t=a.viewControllers[p-1]),t)
```
which corresponds to:
https://github.com/NativeScript/NativeScript/blob/2fc1d8a8d4cf64e98eb98296e21564ac9b508f95/tns-core-modules/ui/action-bar/action-bar.ios.ts#L132
further up `navController` is checked for truthiness:
https://github.com/NativeScript/NativeScript/blob/2fc1d8a8d4cf64e98eb98296e21564ac9b508f95/tns-core-modules/ui/action-bar/action-bar.ios.ts#L119
So applying same logic.
* Adjusted per request
1 parent fb4dad8 commit 324fdce
1 file changed
Lines changed: 7 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -116,7 +116,12 @@ export class ActionBar extends ActionBarBase { | |||
| 116 | 116 | const viewController = (<UIViewController>page.ios); | |
| 117 | 117 | const navigationItem: UINavigationItem = viewController.navigationItem; | |
| 118 | 118 | const navController = <UINavigationController>viewController.navigationController; | |
| 119 | - const navigationBar = navController ? navController.navigationBar : null; | ||
| 119 | + | ||
| 120 | + if (!navController) { | ||
| 121 | + return; | ||
| 122 | + } | ||
| 123 | + | ||
| 124 | + const navigationBar = navController.navigationBar; | ||
| 120 | 125 | let previousController: UIViewController; | |
| 121 | 126 | ||
| 122 | 127 | // Set Title | |
@@ -377,4 +382,4 @@ export class ActionBar extends ActionBarBase { | |||
| 377 | 382 | this.updateFlatness(navBar); | |
| 378 | 383 | } | |
| 379 | 384 | } | |
| 380 | - } | ||
| 385 | + } | ||
0 commit comments