fix: #2796 - ActionItems lacks proper support for VoiceOver on iOS (#… · NativeScript/NativeScript@37d927b · GitHub

NativeScript / NativeScript Public

• Notifications You must be signed in to change notification settings
• Fork 1.7k
• Star 25.7k

• Code
• Issues 775
• Pull requests 73
• Discussions
• Actions
• Projects
• Wiki
• Security and quality
• Insights

Additional navigation options

Commit 37d927b

Browse filesBrowse the repository at this point in the historyBrowse files

m-abs

authored and

Hristo Hristov

committed

fix: #2796 - ActionItems lacks proper support for VoiceOver on iOS (#2799)

UIBarButtonItem weren't created with a title/text so VoiceOver couldn't know what to reads. This marks the element as an AccessibilityElement and sets an accessibilityLabel.

1 parent 0d2d343 commit 37d927b
Copy full SHA for 37d927b

1 file changed

+6Lines changed: 6 additions & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• tns-core-modules/ui/action-bar
  • action-bar.ios.ts

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎tns-core-modules/ui/action-bar/action-bar.ios.ts‎

Copy file name to clipboardExpand all lines: tns-core-modules/ui/action-bar/action-bar.ios.ts

+6Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -159,6 +159,12 @@ export class ActionBar extends common.ActionBar {
159	159	barButtonItem = UIBarButtonItem.alloc().initWithTitleStyleTargetAction(item.text + "", UIBarButtonItemStyle.Plain, tapHandler, "tap");
160	160	}
161	161
	162	+ if (item.text) {
	163	+ barButtonItem.isAccessibilityElement = true;
	164	+ barButtonItem.accessibilityLabel = item.text;
	165	+ barButtonItem.accessibilityTraits = UIAccessibilityTraitButton;
	166	+ }
	167	+
162	168	return barButtonItem;
163	169	}
164	170

0 commit comments

Comments

0 (0)