Ignore the case when getting a response header · NativeScript/NativeScript@37e6e3d · GitHub

NativeScript / NativeScript Public

• Notifications You must be signed in to change notification settings
• Fork 1.7k
• Star 25.7k

• Code
• Issues 773
• Pull requests 69
• Discussions
• Actions
• Projects
• Wiki
• Security and quality
• Insights

Additional navigation options

Commit 37e6e3d

Browse filesBrowse the repository at this point in the historyBrowse files

emelois

committed

Ignore the case when getting a response header

According to the RFC: https://www.w3.org/Protocols/rfc2616/rfc2616-sec4.html#sec4.2 "Field names are case-insensitive". For instance, Google Cloud Endpoints use "content-type" in the response.

1 parent 8fd0476 commit 37e6e3d
Copy full SHA for 37e6e3d

1 file changed

+5-2Lines changed: 5 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• tns-core-modules/xhr
  • xhr.ts

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎tns-core-modules/xhr/xhr.ts‎

Copy file name to clipboardExpand all lines: tns-core-modules/xhr/xhr.ts

+5-2Lines changed: 5 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -194,10 +194,13 @@ export class XMLHttpRequest {
194	194	public getResponseHeader(header: string): string {
195	195	if (types.isString(header) && this._readyState > 1
196	196	&& this._headers
197		- && this._headers[header]
198	197	&& !this._errorFlag
199	198	) {
200		- return this._headers[header];
	199	+ for (var i in this._headers) {
	200	+ if (i.toLowerCase() === header.toLowerCase()) {
	201	+ return this._headers[i];
	202	+ }
	203	+ }
201	204	}
202	205
203	206	return null;

0 commit comments

Comments

0 (0)