FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: fix datepicker tests · NativeScript/NativeScript@5c6a017 · GitHub

Commit 5c6a017

Browse files
committed
test: fix datepicker tests
1 parent 2541167 commit 5c6a017

3 files changed

Lines changed: 16 additions & 15 deletions

File tree

‎tests/app/ui/date-picker/date-picker-tests-native.android.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ export function getNativeYear(datePicker: datePickerModule.DatePicker): number {
55
}
66

77
export function getNativeMonth(datePicker: datePickerModule.DatePicker): number {
8-
return datePicker.android.getMonth() + 1;
8+
return datePicker.android.getMonth();
99
}
1010

1111
export function getNativeDay(datePicker: datePickerModule.DatePicker): number {
@@ -25,13 +25,13 @@ export function setNativeYear(datePicker: datePickerModule.DatePicker, value: nu
2525
}
2626

2727
export function setNativeMonth(datePicker: datePickerModule.DatePicker, value: number): void {
28-
datePicker.android.updateDate(datePicker.android.getYear(), value - 1, datePicker.android.getDayOfMonth());
28+
datePicker.android.updateDate(datePicker.android.getYear(), value, datePicker.android.getDayOfMonth());
2929
}
3030

3131
export function setNativeDay(datePicker: datePickerModule.DatePicker, value: number): void {
3232
datePicker.android.updateDate(datePicker.android.getYear(), datePicker.android.getMonth(), value);
3333
}
3434

3535
export function setNativeDate(datePicker: datePickerModule.DatePicker, year: number, month: number, day: number): void {
36-
datePicker.android.updateDate(year, month - 1, day);
36+
datePicker.android.updateDate(year, month, day);
3737
}

‎tests/app/ui/date-picker/date-picker-tests-native.ios.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ export function getNativeYear(datePicker: datePickerModule.DatePicker): number {
77
}
88

99
export function getNativeMonth(datePicker: datePickerModule.DatePicker): number {
10-
return utils.ios.getter(NSCalendar, NSCalendar.currentCalendar).componentsFromDate(NSCalendarUnit.CalendarUnitYear | NSCalendarUnit.CalendarUnitMonth | NSCalendarUnit.CalendarUnitDay, datePicker.ios.date).month;
10+
return utils.ios.getter(NSCalendar, NSCalendar.currentCalendar).componentsFromDate(NSCalendarUnit.CalendarUnitYear | NSCalendarUnit.CalendarUnitMonth | NSCalendarUnit.CalendarUnitDay, datePicker.ios.date).month - 1;
1111
}
1212

1313
export function getNativeDay(datePicker: datePickerModule.DatePicker): number {
@@ -31,7 +31,7 @@ export function setNativeYear(datePicker: datePickerModule.DatePicker, value: nu
3131

3232
export function setNativeMonth(datePicker: datePickerModule.DatePicker, value: number): void {
3333
var comps = utils.ios.getter(NSCalendar, NSCalendar.currentCalendar).componentsFromDate(NSCalendarUnit.CalendarUnitYear | NSCalendarUnit.CalendarUnitMonth | NSCalendarUnit.CalendarUnitDay, datePicker.ios.date);
34-
comps.month = value;
34+
comps.month = value + 1;
3535
datePicker.ios.setDateAnimated(utils.ios.getter(NSCalendar, NSCalendar.currentCalendar).dateFromComponents(comps), false);
3636
(<any>datePicker)._changeHandler.valueChanged(datePicker.ios);
3737
}
@@ -46,7 +46,7 @@ export function setNativeDay(datePicker: datePickerModule.DatePicker, value: num
4646
export function setNativeDate(datePicker: datePickerModule.DatePicker, year: number, month: number, day: number): void {
4747
var comps = utils.ios.getter(NSCalendar, NSCalendar.currentCalendar).componentsFromDate(NSCalendarUnit.CalendarUnitYear | NSCalendarUnit.CalendarUnitMonth | NSCalendarUnit.CalendarUnitDay, datePicker.ios.date);
4848
comps.year = year;
49-
comps.month = month;
49+
comps.month = month + 1;
5050
comps.day = day;
5151
datePicker.ios.setDateAnimated(utils.ios.getter(NSCalendar, NSCalendar.currentCalendar).dateFromComponents(comps), false);
5252
(<any>datePicker)._changeHandler.valueChanged(datePicker.ios);

‎tests/app/ui/date-picker/date-picker-tests.ts‎

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -95,13 +95,13 @@ export class DatePickerTest extends testModule.UITest<datePickerModule.DatePicke
9595

9696
public test_WhenCreated_DayIsCurrentDay() {
9797
const actualValue = this.testView.day;
98-
const expectedValue = currentDate.getDay();
98+
const expectedValue = currentDate.getDate();
9999
TKUnit.assertEqual(actualValue, expectedValue);
100100
}
101101

102102
public test_WhenCreated_DateIsCurrentDate() {
103103
const expectedValue = currentDate;
104-
assertDate(this.testView, expectedValue.getFullYear(), expectedValue.getMonth(), expectedValue.getDay());
104+
assertDate(this.testView, expectedValue.getFullYear(), expectedValue.getMonth(), expectedValue.getDate());
105105
}
106106

107107
public testYearFromLocalToNative() {
@@ -129,10 +129,11 @@ export class DatePickerTest extends testModule.UITest<datePickerModule.DatePicke
129129
const today = new Date(2016, 3, 15);
130130
this.testView.year = today.getFullYear();
131131
this.testView.month = today.getMonth();
132+
132133
const expectedValue = today.getDate();
133134
this.testView.day = expectedValue;
134135

135-
const expectedDate = new Date(today.getFullYear(), today.getMonth() - 1, expectedValue);
136+
const expectedDate = new Date(today.getFullYear(), today.getMonth(), expectedValue);
136137
TKUnit.assertEqual(this.testView.date.getDate(), expectedDate.getDate(), "Getting Day from date property failed.");
137138
TKUnit.assertEqual(this.testView.date.getMonth(), expectedDate.getMonth(), "Getting Month from date property failed.");
138139
TKUnit.assertEqual(this.testView.date.getFullYear(), expectedDate.getFullYear(), "Getting Year from date property failed.");
@@ -145,7 +146,7 @@ export class DatePickerTest extends testModule.UITest<datePickerModule.DatePicke
145146

146147
const expectedValue = today.getMonth();
147148
this.testView.month = expectedValue;
148-
const expectedDate = new Date(today.getFullYear(), expectedValue - 1, today.getDate());
149+
const expectedDate = new Date(today.getFullYear(), expectedValue, today.getDate());
149150

150151
TKUnit.assertEqual(this.testView.date.getDate(), expectedDate.getDate(), "Getting Day from date property failed.");
151152
TKUnit.assertEqual(this.testView.date.getMonth(), expectedDate.getMonth(), "Getting Month from date property failed.");
@@ -159,7 +160,7 @@ export class DatePickerTest extends testModule.UITest<datePickerModule.DatePicke
159160

160161
const expectedValue = 1980;
161162
this.testView.year = expectedValue;
162-
const expectedDate = new Date(1980, current.getMonth() - 1, current.getDate());
163+
const expectedDate = new Date(1980, current.getMonth(), current.getDate());
163164

164165
TKUnit.assertEqual(this.testView.date.getDate(), expectedDate.getDate(), "Getting Day from date property failed.");
165166
TKUnit.assertEqual(this.testView.date.getMonth(), expectedDate.getMonth(), "Getting Month from date property failed.");
@@ -217,7 +218,7 @@ export class DatePickerTest extends testModule.UITest<datePickerModule.DatePicke
217218

218219
datePickerTestsNative.setNativeDate(this.testView, today.getFullYear(), today.getMonth(), expectedValue);
219220

220-
const expectedDate = new Date(today.getFullYear(), today.getMonth() - 1, expectedValue);
221+
const expectedDate = new Date(today.getFullYear(), today.getMonth(), expectedValue);
221222
TKUnit.assertEqual(this.testView.date.getDate(), expectedDate.getDate(), "Getting Day from date property failed.");
222223
TKUnit.assertEqual(this.testView.date.getMonth(), expectedDate.getMonth(), "Getting Month from date property failed.");
223224
TKUnit.assertEqual(this.testView.date.getFullYear(), expectedDate.getFullYear(), "Getting Year from date property failed.");
@@ -229,7 +230,7 @@ export class DatePickerTest extends testModule.UITest<datePickerModule.DatePicke
229230

230231
datePickerTestsNative.setNativeDate(this.testView, today.getFullYear(), expectedValue, today.getDate());
231232

232-
const expectedDate = new Date(today.getFullYear(), expectedValue - 1, today.getDate());
233+
const expectedDate = new Date(today.getFullYear(), expectedValue, today.getDate());
233234
TKUnit.assertEqual(this.testView.date.getDate(), expectedDate.getDate(), "Getting Day from date property failed.");
234235
TKUnit.assertEqual(this.testView.date.getMonth(), expectedDate.getMonth(), "Getting Month from date property failed.");
235236
TKUnit.assertEqual(this.testView.date.getFullYear(), expectedDate.getFullYear(), "Getting Year from date property failed.");
@@ -241,7 +242,7 @@ export class DatePickerTest extends testModule.UITest<datePickerModule.DatePicke
241242
const expectedValue = 1981;
242243
datePickerTestsNative.setNativeDate(this.testView, expectedValue, today.getMonth(), today.getDate());
243244

244-
const expectedDate = new Date(expectedValue, today.getMonth() - 1, today.getDate());
245+
const expectedDate = new Date(expectedValue, today.getMonth(), today.getDate());
245246
TKUnit.assertEqual(this.testView.date.getDate(), expectedDate.getDate(), "Getting Day from date property failed.");
246247
TKUnit.assertEqual(this.testView.date.getMonth(), expectedDate.getMonth(), "Getting Month from date property failed.");
247248
TKUnit.assertEqual(this.testView.date.getFullYear(), expectedDate.getFullYear(), "Getting Year from date property failed.");
@@ -253,7 +254,7 @@ export class DatePickerTest extends testModule.UITest<datePickerModule.DatePicke
253254
const testDay = 24;
254255

255256
datePickerTestsNative.setNativeDate(this.testView, testYear, testMonth, testDay);
256-
const expectedDate = new Date(testYear, testMonth - 1, testDay);
257+
const expectedDate = new Date(testYear, testMonth, testDay);
257258
TKUnit.assertEqual(this.testView.date.getDate(), expectedDate.getDate(), "Getting Day from date property failed.");
258259
TKUnit.assertEqual(this.testView.date.getMonth(), expectedDate.getMonth(), "Getting Month from date property failed.");
259260
TKUnit.assertEqual(this.testView.date.getFullYear(), expectedDate.getFullYear(), "Getting Year from date property failed.");

0 commit comments

Comments
 (0)

Back | FazBrowse Home | New Git URL