fix(xml parser): Fix text node data event. · NativeScript/NativeScript@67cfab2 · GitHub

NativeScript / NativeScript Public

• Notifications You must be signed in to change notification settings
• Fork 1.7k
• Star 25.7k

• Code
• Issues 773
• Pull requests 69
• Discussions
• Actions
• Projects
• Wiki
• Security and quality
• Insights

Additional navigation options

Commit 67cfab2

Browse filesBrowse the repository at this point in the historyBrowse files

hdeshev

committed

fix(xml parser): Fix text node data event.

1 parent 7ce98a7 commit 67cfab2
Copy full SHA for 67cfab2

2 files changed

+10-1Lines changed: 10 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• js-libs/easysax
  • easysax.js
• node-tests
  • test-xml.ts

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎js-libs/easysax/easysax.js‎

Copy file name to clipboardExpand all lines: js-libs/easysax/easysax.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -105,7 +105,7 @@ EasySAXParser.prototype.on = function(name, cb) {
105	105	case 'error': this.onError = cb || nullFunc; break;
106	106	case 'startNode': this.onStartNode = cb || nullFunc; break;
107	107	case 'endNode': this.onEndNode = cb || nullFunc; break;
108		- case 'textNode': onTextNode = cb || nullFunc; break;
	108	+ case 'textNode': this.onTextNode = cb || nullFunc; break;
109	109	case 'cdata': this.onCDATA = cb || nullFunc; break;
110	110
111	111	case 'comment': this.onComment = cb; this.is_onComment = !!cb; break;

Collapse file

‎node-tests/test-xml.ts‎

Copy file name to clipboardExpand all lines: node-tests/test-xml.ts

+9Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -4,6 +4,7 @@ import xml = require('xml');
4	4	describe("xml parser", () => {
5	5	let last_element = null;
6	6	let last_attrs = null;
	7	+ let last_data = null;
7	8	let parser = null;
8	9
9	10	beforeEach(() => {
@@ -13,6 +14,9 @@ describe("xml parser", () => {
13	14	last_element = event.elementName;
14	15	last_attrs = event.attributes;
15	16	break;
	17	+ case xml.ParserEventType.Text:
	18	+ last_data = event.data;
	19	+ break;
16	20	}
17	21	});
18	22	});
@@ -26,4 +30,9 @@ describe("xml parser", () => {
26	30	assert.equal('TextField', last_element);
27	31	assert.equal('hello', last_attrs['text']);
28	32	});
	33	+
	34	+ it("resolves entities", () => {
	35	+ parser.parse("<element>&lt;&gt;&quot;&amp;&apos;</element>");
	36	+ assert.equal("<>\"&'", last_data);
	37	+ });
29	38	});

0 commit comments

Comments

0 (0)