fix(android): remove wait for doubletap if no gesture recognizer (#7584) · NativeScript/NativeScript@9fd5ddc · GitHub

NativeScript / NativeScript Public

• Notifications You must be signed in to change notification settings
• Fork 1.7k
• Star 25.7k

• Code
• Issues 773
• Pull requests 69
• Discussions
• Actions
• Projects
• Wiki
• Security and quality
• Insights

Additional navigation options

Commit 9fd5ddc

Browse filesBrowse the repository at this point in the historyBrowse files

MartoYankov

authored and

SvetoslavTsenov

committed

fix(android): remove wait for doubletap if no gesture recognizer (#7584)

1 parent 490cab0 commit 9fd5ddc
Copy full SHA for 9fd5ddc

1 file changed

+10-3Lines changed: 10 additions & 3 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• tns-core-modules/ui/gestures
  • gestures.android.ts

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎tns-core-modules/ui/gestures/gestures.android.ts‎

Copy file name to clipboardExpand all lines: tns-core-modules/ui/gestures/gestures.android.ts

+10-3Lines changed: 10 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -68,13 +68,20 @@ function initializeTapAndDoubleTapGestureListener() {
68	68	}
69	69
70	70	private _handleSingleTap(motionEvent: android.view.MotionEvent): void {
71		- this._tapTimeoutId = timer.setTimeout(() => {
	71	+ if (this._target.getGestureObservers(GestureTypes.doubleTap)) {
	72	+ this._tapTimeoutId = timer.setTimeout(() => {
	73	+ if (this._type & GestureTypes.tap) {
	74	+ const args = _getArgs(GestureTypes.tap, this._target, motionEvent);
	75	+ _executeCallback(this._observer, args);
	76	+ }
	77	+ timer.clearTimeout(this._tapTimeoutId);
	78	+ }, TapAndDoubleTapGestureListenerImpl.DoubleTapTimeout);
	79	+ } else {
72	80	if (this._type & GestureTypes.tap) {
73	81	const args = _getArgs(GestureTypes.tap, this._target, motionEvent);
74	82	_executeCallback(this._observer, args);
75	83	}
76		- timer.clearTimeout(this._tapTimeoutId);
77		- }, TapAndDoubleTapGestureListenerImpl.DoubleTapTimeout);
	84	+ }
78	85	}
79	86
80	87	private _handleDoubleTap(motionEvent: android.view.MotionEvent): void {

0 commit comments

Comments

0 (0)