fix(image): tintColor on iOS was not applied correctly · NativeScript/NativeScript@b280efe · GitHub

NativeScript / NativeScript Public

• Notifications You must be signed in to change notification settings
• Fork 1.7k
• Star 25.7k

• Code
• Issues 775
• Pull requests 73
• Discussions
• Actions
• Projects
• Wiki
• Security and quality
• Insights

Additional navigation options

Commit b280efe

Browse filesBrowse the repository at this point in the historyBrowse files

ddfreiling

committed

fix(image): tintColor on iOS was not applied correctly

only reset image to non-template when tintColor is changed to a non-color (removed)

1 parent af934cc commit b280efe
Copy full SHA for b280efe

1 file changed

+2-2Lines changed: 2 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• tns-core-modules/ui/image
  • image.ios.ts

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎tns-core-modules/ui/image/image.ios.ts‎

Copy file name to clipboardExpand all lines: tns-core-modules/ui/image/image.ios.ts

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -25,7 +25,7 @@ export class Image extends ImageBase {
25	25	if (value && this.nativeViewProtected.image && !this._templateImageWasCreated) {
26	26	this.nativeViewProtected.image = this.nativeViewProtected.image.imageWithRenderingMode(UIImageRenderingMode.AlwaysTemplate);
27	27	this._templateImageWasCreated = true;
28		- } else if (this.nativeViewProtected.image && this._templateImageWasCreated) {
	28	+ } else if (!value && this.nativeViewProtected.image && this._templateImageWasCreated) {
29	29	this._templateImageWasCreated = false;
30	30	this.nativeViewProtected.image = this.nativeViewProtected.image.imageWithRenderingMode(UIImageRenderingMode.Automatic);
31	31	}
@@ -48,7 +48,7 @@ export class Image extends ImageBase {
48	48	}
49	49
50	50	public onMeasure(widthMeasureSpec: number, heightMeasureSpec: number): void {
51		- // We don't call super because we measure native view with specific size.
	51	+ // We don't call super because we measure native view with specific size.
52	52	const width = layout.getMeasureSpecSize(widthMeasureSpec);
53	53	const widthMode = layout.getMeasureSpecMode(widthMeasureSpec);
54	54

0 commit comments

Comments

0 (0)