FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Merge pull request #803 from NativeScript/text-field-hint · NativeScript/NativeScript@b733c59 · GitHub

/ NativeScript Public

Commit b733c59

Browse files
Vladimir Enchev
committed
Merge pull request #803 from NativeScript/text-field-hint
text-field hint now can be set to number
2 parents c07ac6c + e0d4757 commit b733c59

3 files changed

Lines changed: 19 additions & 2 deletions

File tree

‎apps/tests/ui/text-field/text-field-tests.ts‎

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,24 @@ export var testSetText = function () {
6767
TKUnit.assert(actualValue === expectedValue, "Actual: " + actualValue + "; Expected: " + expectedValue);
6868
});
6969
}
70+
/* tslint:disable */
71+
export var testSetHintToNumber = function () {
72+
helper.buildUIAndRunTest(_createTextFieldFunc(), function (views: Array<viewModule.View>) {
73+
var textField = <textFieldModule.TextField>views[0];
74+
var expectedValue = 1;
7075

76+
// <snippet module="ui/text-field" title="TextField">
77+
// ### Setting the text of a TextField
78+
// ``` JavaScript
79+
textField.hint = <any>expectedValue;
80+
// ```
81+
// </snippet>
82+
83+
var actualValue = textFieldTestsNative.getNativeHint(textField);
84+
TKUnit.assert(<any>actualValue == expectedValue, "Actual: " + actualValue + "; Expected: " + expectedValue);
85+
});
86+
}
87+
/* tslint:enable */
7188
export var testBindTextDirectlyToModel = function () {
7289
helper.buildUIAndRunTest(_createTextFieldFunc(), function (views: Array<viewModule.View>) {
7390
var textField = <textFieldModule.TextField>views[0];

‎ui/editable-text-base/editable-text-base.android.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -260,6 +260,6 @@ export class EditableTextBase extends common.EditableTextBase {
260260
return;
261261
}
262262

263-
editableTextBase.android.setHint(data.newValue);
263+
editableTextBase.android.setHint(data.newValue + "");
264264
}
265265
}

‎ui/text-field/text-field.ios.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,6 @@ export class TextField extends common.TextField {
130130

131131
public _onHintPropertyChanged(data: dependencyObservable.PropertyChangeData) {
132132
var textField = <TextField>data.object;
133-
textField.ios.placeholder = data.newValue;
133+
textField.ios.placeholder = data.newValue + "";
134134
}
135135
}

0 commit comments

Comments
 (0)
Back | FazBrowse Home | New Git URL