fix(android-textfield): returnPress fired twice for GO/SEARCH/SEND (#… · NativeScript/NativeScript@ca444aa · GitHub

NativeScript / NativeScript Public

• Notifications You must be signed in to change notification settings
• Fork 1.7k
• Star 25.7k

• Code
• Issues 773
• Pull requests 69
• Discussions
• Actions
• Projects
• Wiki
• Security and quality
• Insights

Additional navigation options

Commit ca444aa

Browse filesBrowse the repository at this point in the historyBrowse files

manoldonev

authored

fix(android-textfield): returnPress fired twice for GO/SEARCH/SEND (#5727)

1 parent a86d41e commit ca444aa
Copy full SHA for ca444aa

1 file changed

+4-10Lines changed: 4 additions & 10 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• tns-core-modules/ui/editable-text-base
  • editable-text-base.android.ts

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎tns-core-modules/ui/editable-text-base/editable-text-base.android.ts‎

Copy file name to clipboardExpand all lines: tns-core-modules/ui/editable-text-base/editable-text-base.android.ts

+4-10Lines changed: 4 additions & 10 deletions

Original file line number	Diff line number	Diff line change
@@ -115,12 +115,8 @@ function initializeEditTextListeners(): void {
115	115	return false;
116	116	}
117	117
118		- if (actionId === android.view.inputmethod.EditorInfo.IME_NULL ||
	118	+ if (actionId === android.view.inputmethod.EditorInfo.IME_ACTION_DONE ||
119	119	actionId === android.view.inputmethod.EditorInfo.IME_ACTION_UNSPECIFIED ||
120		- actionId === android.view.inputmethod.EditorInfo.IME_ACTION_DONE ||
121		- actionId === android.view.inputmethod.EditorInfo.IME_ACTION_GO ||
122		- actionId === android.view.inputmethod.EditorInfo.IME_ACTION_SEARCH ||
123		- actionId === android.view.inputmethod.EditorInfo.IME_ACTION_SEND ||
124	120	(event && event.getKeyCode() === android.view.KeyEvent.KEYCODE_ENTER)) {
125	121	// If it is TextField, close the keyboard. If it is TextView, do not close it since the TextView is multiline
126	122	// https://github.com/NativeScript/NativeScript/issues/3111
@@ -129,11 +125,9 @@ function initializeEditTextListeners(): void {
129	125	}
130	126
131	127	owner._onReturnPress();
132		- }
133		-
134		- // If action is ACTION_NEXT then do not close keyboard
135		- if (actionId === android.view.inputmethod.EditorInfo.IME_ACTION_NEXT
136		- || actionId === android.view.inputmethod.EditorInfo.IME_ACTION_PREVIOUS) {
	128	+ } else if (actionId === android.view.inputmethod.EditorInfo.IME_ACTION_NEXT ||
	129	+ actionId === android.view.inputmethod.EditorInfo.IME_ACTION_PREVIOUS) {
	130	+ // do not close keyboard for ACTION_NEXT or ACTION_PREVIOUS
137	131	owner._onReturnPress();
138	132	}
139	133

0 commit comments

Comments

0 (0)