fix(animation): handle promise rejection and avoid throw · NativeScript/NativeScript@d80bb16 · GitHub

NativeScript / NativeScript Public

• Notifications You must be signed in to change notification settings
• Fork 1.7k
• Star 25.7k

• Code
• Issues 781
• Pull requests 73
• Discussions
• Actions
• Projects
• Wiki
• Security and quality
• Insights

Additional navigation options

Commit d80bb16

Browse filesBrowse the repository at this point in the historyBrowse files

NathanWalker

committed

fix(animation): handle promise rejection and avoid throw

1 parent 7851629 commit d80bb16
Copy full SHA for d80bb16

1 file changed

+3-3Lines changed: 3 additions & 3 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• tns-core-modules/ui/animation
  • keyframe-animation.ts

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎tns-core-modules/ui/animation/keyframe-animation.ts‎

Copy file name to clipboardExpand all lines: tns-core-modules/ui/animation/keyframe-animation.ts

+3-3Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -239,10 +239,10 @@ export class KeyframeAnimation implements KeyframeAnimationDefinition {
239	239	// Catch the animation cancel to prevent unhandled promise rejection warnings
240	240	animation.play().then(() => {
241	241	this.animate(view, index + 1, iterations);
	242	+ }, (error: any) => {
	243	+ traceWrite(typeof error === 'string' ? error : error.message, traceCategories.Animation, traceType.warn);
242	244	}).catch((error: any) => {
243		- if (error.message.indexOf("Animation cancelled") < 0) {
244		- throw error;
245		- }
	245	+ traceWrite(typeof error === 'string' ? error : error.message, traceCategories.Animation, traceType.warn);
246	246	}); // tslint:disable-line
247	247	this._nativeAnimations.push(animation);
248	248	}

0 commit comments

Comments

0 (0)