fix(android): failure saving state in mixed parent/nested frame nav (… · NativeScript/NativeScript@e5f110f · GitHub

NativeScript / NativeScript Public

• Notifications You must be signed in to change notification settings
• Fork 1.7k
• Star 25.7k

• Code
• Issues 773
• Pull requests 69
• Discussions
• Actions
• Projects
• Wiki
• Security and quality
• Insights

Additional navigation options

Commit e5f110f

Browse filesBrowse the repository at this point in the historyBrowse files

manoldonev

authored and

SvetoslavTsenov

committed

fix(android): failure saving state in mixed parent/nested frame nav (#6719)

1 parent 54b6df6 commit e5f110f
Copy full SHA for e5f110f

1 file changed

+6Lines changed: 6 additions & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• tns-core-modules/ui/frame
  • frame.android.ts

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎tns-core-modules/ui/frame/frame.android.ts‎

Copy file name to clipboardExpand all lines: tns-core-modules/ui/frame/frame.android.ts

+6Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -903,6 +903,12 @@ class FragmentCallbacksImplementation implements AndroidFragmentCallbacks {
903	903	return null;
904	904	}
905	905
	906	+ // [nested frames / fragments] see https://github.com/NativeScript/NativeScript/issues/6629
	907	+ // retaining reference to a destroyed fragment here somehow causes a cryptic
	908	+ // "IllegalStateException: Failure saving state: active fragment has cleared index: -1"
	909	+ // in a specific mixed parent / nested frame navigation scenario
	910	+ entry.fragment = null;
	911	+
906	912	const page = entry.resolvedPage;
907	913	if (!page) {
908	914	traceError(`${fragment}.onDestroy: entry has no resolvedPage`);

0 commit comments

Comments

0 (0)