Revert "fix-next(android): restore fade animation for simulated nav (… · NativeScript/NativeScript@eba75a5 · GitHub

NativeScript / NativeScript Public

• Notifications You must be signed in to change notification settings
• Fork 1.7k
• Star 25.7k

• Code
• Issues 781
• Pull requests 73
• Discussions
• Actions
• Projects
• Wiki
• Security and quality
• Insights

Additional navigation options

Commit eba75a5

Browse filesBrowse the repository at this point in the historyBrowse files

manoldonev

authored

Revert "fix-next(android): restore fade animation for simulated nav (#6463)"

This reverts commit 448936d.

1 parent 448936d commit eba75a5
Copy full SHA for eba75a5

1 file changed

+1-1Lines changed: 1 addition & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• tns-core-modules/ui/frame
  • frame.android.ts

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎tns-core-modules/ui/frame/frame.android.ts‎

Copy file name to clipboardExpand all lines: tns-core-modules/ui/frame/frame.android.ts

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -364,7 +364,7 @@ export class Frame extends FrameBase {
364	364	const newFragmentTag = `fragment${fragmentId}[${navDepth}]`;
365	365	const newFragment = this.createFragment(newEntry, newFragmentTag);
366	366	const transaction = manager.beginTransaction();
367		- const animated = this._getIsAnimatedNavigation(newEntry.entry);
	367	+ const animated = currentEntry ? this._getIsAnimatedNavigation(newEntry.entry) : false;
368	368	// NOTE: Don't use transition for the initial navigation (same as on iOS)
369	369	// On API 21+ transition won't be triggered unless there was at least one
370	370	// layout pass so we will wait forever for transitionCompleted handler...

0 commit comments

Comments

0 (0)