fix(observable-array): splice to notify correct amount of added items… · NativeScript/NativeScript@f384d89 · GitHub

NativeScript / NativeScript Public

• Notifications You must be signed in to change notification settings
• Fork 1.7k
• Star 25.7k

• Code
• Issues 775
• Pull requests 73
• Discussions
• Actions
• Projects
• Wiki
• Security and quality
• Insights

Additional navigation options

Commit f384d89

Browse filesBrowse the repository at this point in the historyBrowse files

edusperoni

authored and

SvetoslavTsenov

committed

fix(observable-array): splice to notify correct amount of added items (#7426)

1 parent aa5d861 commit f384d89
Copy full SHA for f384d89

2 files changed

+3-3Lines changed: 3 additions & 3 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• tests/app/data
  • observable-array-tests.ts
• tns-core-modules/data/observable-array
  • observable-array.ts

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎tests/app/data/observable-array-tests.ts‎

Copy file name to clipboardExpand all lines: tests/app/data/observable-array-tests.ts

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -410,7 +410,7 @@ export const test_ObservableArray_spliceShouldRemoveAndInertSpecifiedNumberOfEle
410	410	// args.action is "splice".
411	411	// args.index is the start index.
412	412	// args.removed.length is equal to the number of deleted items.
413		- // args.addedCount is equal to the delta between number of inserted items and number of deleted items but not less than 0.
	413	+ // args.addedCount is equal to the amount of added and replaced items.
414	414
415	415	// >> (hide)
416	416	result = args;
@@ -421,7 +421,7 @@ export const test_ObservableArray_spliceShouldRemoveAndInertSpecifiedNumberOfEle
421	421	// << observable-array-splice-args-change
422	422
423	423	TKUnit.assert(result.eventName === ObservableArray.changeEvent && result.action === ChangeType.Splice &&
424		- result.removed.length === 2 && result.index === 1 && result.addedCount === 1, "ObservableArray splice() should raise 'change' event with correct args!");
	424	+ result.removed.length === 2 && result.index === 1 && result.addedCount === 3, "ObservableArray splice() should raise 'change' event with correct args!");
425	425	};
426	426
427	427	export const test_ObservableArray_unshiftShouldInsertNewElementsFromTheStart = function () {

Collapse file

‎tns-core-modules/data/observable-array/observable-array.ts‎

Copy file name to clipboardExpand all lines: tns-core-modules/data/observable-array/observable-array.ts

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -207,7 +207,7 @@ export class ObservableArray<T> extends observable.Observable implements observa
207	207	action: ChangeType.Splice,
208	208	index: start,
209	209	removed: result,
210		- addedCount: this._array.length > length ? this._array.length - length : 0
	210	+ addedCount: this._array.length + result.length - length
211	211	});
212	212	if (this._array.length !== length) {
213	213	this._notifyLengthChange();

0 commit comments

Comments

0 (0)